devel/android-tools-adb

devel/android-tools: New port: Android debugging tools

While I'm here, remove the old devel/android-tools-adb and
devel/android-tools-fastboot ports. These ports are long out-of-date
and the adb port especially had issues with certain devices.

This port was tested from a FreeBSD 14.0 system to flash both
LineageOS and GrapheneOS on a Google Pixel 3 using both `adb` and
`fastboot`.

devel/android-tools-adb: Release MAINTAINER

*/*: Remove redundant '-*' from CONFLICTS definitions

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

devel/android-tools-adb: Adopt port

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

Drop illusion of maintenance

Gift important ports (reset if undesired):
- multimedia/libmtp -> desktop@
- x11-drivers/xf86-input-wacom -> x11@

devel/android-tools-adb: drop lang/python27 dependency

-Ran 51 tests in 5.527s
+Ran 62 tests in 17.952s

PR:		249607

devel/android-tools-adb: move _unsupported after r511280

make[2]: don't know how to make client/transport_mdns_unsupported.cpp. Stop

devel/android-tools-adb: fix TEST=on after r527733

socket_spec_test.cpp:101: Failure
Expected equality of these values:
  5555
  get_host_socket_spec_port("vsock:5555", &error)
    Which is: -1

* thread #1, name = 'adb_test', stop reason = signal SIGILL: privileged instruction
    frame #0: 0x00000000003fc604 adb_test`GetThreadId() at logger_write.cpp:240:31
   237  #endif
   238
   239  // Copied from base/threads.cpp
-> 240  static uint64_t GetThreadId() {
   241  #if defined(__BIONIC__)
   242    return gettid();
   243  #elif defined(__APPLE__)
(lldb) bt
* thread #1, name = 'adb_test', stop reason = signal SIGILL: privileged instruction
  * frame #0: 0x00000000003fc604 adb_test`GetThreadId() at logger_write.cpp:240:31
    frame #1: 0x00000000003fc3ce adb_test`::__android_log_stderr_logger(logger_data=0x00007fffffffce60, message="foobar") at logger_write.cpp:274:18
    frame #2: 0x00000000003fc92a adb_test`::__android_log_write_logger_data(logger_data=0x00007fffffffce60, msg="foobar") at logger_write.cpp:329:3
    frame #3: 0x00000000003f6c44 adb_test`android::base::LogMessage::LogLine(file="logging_test.cpp", line=603, severity=ERROR, tag=0x0000000000000000, message="foobar") at logging.cpp:581:5
    frame #4: 0x00000000003f683d adb_test`android::base::LogMessage::~LogMessage(this=0x00007fffffffd000) at logging.cpp:542:7
    frame #5: 0x00000000004f76fe adb_test`TestLoggingInConstructor() at logging_test.cpp:603:3

* thread #1, name = 'adb_test', stop reason = signal SIGSEGV: invalid address (fault address: 0x14)
    frame #0: 0x00000000004c8dc8 adb_test`file_RemoveFileIfExists_EACCES_Test::TestBody(this=0x0000000800f91060) at file_test.cpp:247:19
   244    // root can bypass permission restrictions, so drop root.
   245    if (getuid() == 0) {
   246      passwd* shell = getpwnam("shell");
-> 247      setgid(shell->pw_gid);
   248      setuid(shell->pw_uid);
   249    }
   250
(lldb) bt
* thread #1, name = 'adb_test', stop reason = signal SIGSEGV: invalid address (fault address: 0x14)
  * frame #0: 0x00000000004c8dc8 adb_test`file_RemoveFileIfExists_EACCES_Test::TestBody(this=0x0000000800f91060) at file_test.cpp:247:19
    frame #1: 0x0000000800982d6e libgtest.so`void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(object=0x0000000800f91060, method=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, location="the test body")(), char const*) at gtest.cc:2433:10
    frame #2: 0x0000000800962399 libgtest.so`void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(object=0x0000000800f91060, method=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, location="the test body")(), char const*) at gtest.cc:2469:14
    frame #3: 0x0000000800942b43 libgtest.so`testing::Test::Run(this=0x0000000800f91060) at gtest.cc:2508:5
    frame #4: 0x0000000800943792 libgtest.so`testing::TestInfo::Run(this=0x0000000800fa3ba0) at gtest.cc:2684:11
    frame #5: 0x0000000800943e17 libgtest.so`testing::TestSuite::Run(this=0x0000000800fa34a0) at gtest.cc:2816:28
    frame #6: 0x0000000800950480 libgtest.so`testing::internal::UnitTestImpl::RunAllTests(this=0x0000000800fa4000) at gtest.cc:5338:44
    frame #7: 0x0000000800987bfe libgtest.so`bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(object=0x0000000800fa4000, method=40 00 95 00 08 00 00 00 00 00 00 00 00 00 00 00, location="auxiliary test code (environments or event listeners)")(), char const*) at gtest.cc:2433:10
    frame #8: 0x00000008009650a9 libgtest.so`bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(object=0x0000000800fa4000, method=40 00 95 00 08 00 00 00 00 00 00 00 00 00 00 00, location="auxiliary test code (environments or event listeners)")(), char const*) at gtest.cc:2469:14
    frame #9: 0x000000080094ffd4 libgtest.so`testing::UnitTest::Run(this=0x000000080099a0d8) at gtest.cc:4925:10
    frame #10: 0x0000000000543cf1 adb_test`RUN_ALL_TESTS() at gtest.h:2473:46
    frame #11: 0x0000000000543c70 adb_test`main(argc=1, argv=0x00007fffffffeae8) at test_main.cpp:24:10
    frame #12: 0x000000000031710f adb_test`_start(ap=<unavailable>, cleanup=<unavailable>) at crt1.c:76:7

PR:		245642
Submitted by:	Marcin Cieślak (based on)

devel/android-tools-adb: drop FreeBSD 12.0 support after r527628

devel/android-tools-{adb,fastboot}: update to 29.0.6

Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.5..platform-tools-29.0.6/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.5..platform-tools-29.0.6/fastboot
Reported by:	portscout

devel/googletest: merge googlemock

Avoid micromanaging installed files to simplify maintenance.
Already done upstream since 1.8.0. Other distributions (e.g.,
Arch, PkgSrc) have followed.

Fix build with src r354909 applied.

The referenced change made NO_INSTALLLIB, NO_MAN, and NO_PROFILE into
errors causing these ports that declare them and use the FreeBSD make
infrastructure as part of their build to fail.

When the offending variables occur in a BSD Makefile, NO_MAN becomes
MAN= and NO_INSTALLLIB and NO_PROFILE become MK_INSTALLLIB=no and
MK_PROFILE=no respectively.  When declared in the environment they
become WITHOUT_<FOO>.

devel/android-tools-{adb,fastboot}: update to 29.0.5

Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.4..platform-tools-29.0.5/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.4..platform-tools-29.0.5/fastboot
Reported by:	portscout

devel/google{test,mock}: update to 1.10.0

- Drop static library
- Drop gtest-config and gmock-config
- Drop GTEST_LIB_CHECK autoconf macro
- Drop gmock_doctory.py as it's too old
- Expose tests via option

Changes:	https://github.com/google/googletest/compare/release-1.8.1...release-1.10.0
Reported by:	GitHub (watch releases)
PR:		239654
Differential Revision:	https://reviews.freebsd.org/D19430

devel/android-tools-{adb,fastboot}: update to 29.0.4

Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.3..platform-tools-29.0.4/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.3..platform-tools-29.0.4/fastboot
Reported by:	portscout

devel/android-tools-*: simplify via GH_TUPLE

Also, chase HTTP redirect in simpleperf

devel/android-tools-adb: drop unused files after r448522 and r477244

https://android.googlesource.com/platform/system/core/+/e8b663fec3ac%5E%21/
https://android.googlesource.com/platform/system/core/+/e5dd71a290f6%5E%21/
https://android.googlesource.com/platform/system/core/+/d51c6df1ef98%5E%21/

devel/android-tools-adb: update to 29.0.3

Changes:	https://android.googlesource.com/platform/system/core/+log/platform-tools-29.0.2..platform-tools-29.0.3/adb
Reported by:	portscout

devel/android-tools-adb: zlib is unused since r398924

devel/android-tools-adb: update to 29.0.2

Changes:	https://android.googlesource.com/platform/system/core/+log/android-9.0.0_r3..platform-tools-29.0.2/adb

devel/android-tools-adb: glob(3) in FILES doesn't work on FreeBSD 12.0

Bump PORTREVISION for ports depending on the canonical version of GCC as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3 to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Add more gettid() aliases to my ports

https://man.openbsd.org/getthrid.2
https://illumos.org/man/3C/thr_self

Switch DragonFly to pthread_getthreadid_np in my ports

https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c0f25c26521a

devel/android-tools-adb: back out r498558 for breaking other BSDs

g++: error: ../libcutils/sockets.o: No such file or directory

devel/android-tools-adb: switch to LIBUSB_CAP_HAS_HOTPLUG whitelist

$ adb connect 1.2.3.4
* daemon not running; starting now at tcp:5037
ADB server didn't ACK
Full server startup log: /tmp/adb.1000.log
Server had pid: 1193
--- adb starting (pid 1193) ---
adb I 12-31 10:41:58  1193     1 main.cpp:56] Android Debug Bridge version 1.0.40
adb I 12-31 10:41:58  1193     1 main.cpp:56] Version 28.0.0-0
adb I 12-31 10:41:58  1193     1 main.cpp:56] Installed as /usr/pkg/bin/adb
adb I 12-31 10:41:58  1193     1 main.cpp:56]
adb F 12-31 10:41:58  1193     1 usb_libusb.cpp:517] failed to register libusb hotplug callback

* failed to start daemon
error: cannot connect to daemon

devel/android-tools-adb: drop FreeBSD < 10.2 support after r430462

devel/android-tools-adb: move SDK_VERSION into vendor Makefile

During major updates SDK version indirectly reflects changed files.

devel/android-tools-adb: drop unused variable after r448522

devel/android-tools-adb: skip manpage on NetBSD as well

make: don't know how to make adb.1. Stop

Bump PORTREVISION for ports depending on the canonical version of GCC defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

devel/android-tools-adb: apply boringssl style fixes

http://github.com/google/boringssl/commit/54091230cda4
http://github.com/google/boringssl/commit/808f8329177f

devel/android-tools-adb: unbreak with OpenSSL 1.1

adb/../libcrypto_utils/android_pubkey.c:84:10: error: incomplete definition of type 'struct rsa_st'
  new_key->n = BN_bin2bn(modulus_buffer, sizeof(modulus_buffer), NULL);
  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:85:15: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->n) {
       ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:90:10: error: incomplete definition of type 'struct rsa_st'
  new_key->e = BN_new();
  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:91:15: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->e || !BN_set_word(new_key->e, key_struct->exponent)) {
       ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:91:42: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->e || !BN_set_word(new_key->e, key_struct->exponent)) {
                                  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:138:18: error: incomplete definition of type 'struct bignum_st'
  BN_ULONG l = in->d[constant_time_select_ulong(
               ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:139:33: error: incomplete definition of type 'struct bignum_st'
      constant_time_le_size_t(in->dmax, i), in->dmax - 1, i)];
                              ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:139:47: error: incomplete definition of type 'struct bignum_st'
      constant_time_le_size_t(in->dmax, i), in->dmax - 1, i)];
                                            ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:142:63: error: incomplete definition of type 'struct bignum_st'
  return constant_time_select_ulong(constant_time_le_size_t(in->top, i), 0, l);
                                                            ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:157:17: error: incomplete definition of type 'struct bignum_st'
  if ((size_t)in->top > (len + (BN_BYTES - 1)) / BN_BYTES) {
              ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:210:25: error: incomplete definition of type 'struct rsa_st'
      !BN_mod(n0inv, key->n, r32, ctx) ||
                     ~~~^
/usr/include/openssl/bn.h:247:49: note: expanded from macro 'BN_mod'
 # define BN_mod(rem,m,d,ctx) BN_div(NULL,(rem),(m),(d),(ctx))
                                                 ^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:217:40: error: incomplete definition of type 'struct rsa_st'
  if (!android_pubkey_encode_bignum(key->n, key_struct->modulus)) {
                                    ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:223:30: error: incomplete definition of type 'struct rsa_st'
      !BN_mod_sqr(rr, rr, key->n, ctx) ||
                          ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:229:51: error: incomplete definition of type 'struct rsa_st'
  key_struct->exponent = (uint32_t)BN_get_word(key->e);
                                               ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^

Reported by:	pkg-fallout

devel/google{test,mock}: update to 1.8.1

Changes:	https://github.com/google/googletest/compare/9bda90b...release-1.8.1

devel/android-tools-adb: drop unused file after r453204

devel/android-tools-adb: adjust for USB dispatch on Windows after r477245

See https://android.googlesource.com/platform/system/core/+/9425996b4521%5E!/

devel/android-tools-adb: unbreak on DragonFly after r477244

adb/client/usb_libusb.cpp: In function 'void libusb::poll_for_devices()':
adb/client/usb_libusb.cpp:493:43: error: unable to find numeric literal operator 'operator""ms'
         if (device_poll_cv.wait_for(lock, 500ms, []() { return terminate_device_poll_thread; })) {
                                           ^~~~~

devel/android-tools-{adb,fastboot}: update to 9.0.0.r3

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.1.0_r2..android-9.0.0_r3/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.1.0_r2..android-9.0.0_r3/fastboot
MFH:		2018Q3 (mostly bug fixes)

devel/android-tools-adb: update SDK version as part of makesum

- Extract platform SDK version out of platform/build repo
- Move version logic out of sub-makefile
- Simplify GH_REVISION

devel/android-tools-{adb,fastboot}: chase SDK version in --version after r456869

Keep in mind, the output is still not identical to upstream.

  $ platform-tools_r26.0.0-linux/adb version
  Android Debug Bridge version 1.0.39
  Revision 3db08f2c6889-android
  Installed as /tmp/platform-tools_r26.0.0-linux/adb

  $ platform-tools_r26.0.0-linux/fastboot --version
  fastboot version 3db08f2c6889-android
  Installed as /tmp/platform-tools_r26.0.0-linux/fastboot

  $ platform-tools_r27.0.0-linux/adb version
  Android Debug Bridge version 1.0.39
  Version 27.0.0-4455170
  Installed as /tmp/platform-tools_r27.0.0-linux/adb

  $ platform-tools_r27.0.0-linux/fastboot --version
  fastboot version 27.0.0-4455170
  Installed as /tmp/platform-tools_r27.0.0-linux/fastboot

  $ adb version
  Android Debug Bridge version 1.0.39
  Version 27.0.0-0 86c2b588a369-android
  Installed as /usr/local/bin/adb

  $ fastboot --version
  fastboot version 27.0.0-0 86c2b588a369-android
  Installed as /usr/local/bin/fastboot

devel/android-tools-{adb,fastboot}: chase HTTP redirect

devel/android-tools-{adb,fastboot}-devel: remove for being older than master port

devel/android-tools-{adb,fastboot}: update to 8.1.0.r2

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r24..android-8.1.0_r2/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r24..android-8.1.0_r2/fastboot

Convert Python ports to FLAVORS.

Ports using USE_PYTHON=distutils are now flavored.  They will
  automatically get flavors (py27, py34, py35, py36) depending on what
  versions they support.

  There is also a USE_PYTHON=flavors for ports that do not use distutils
  but need FLAVORS to be set.  A USE_PYTHON=noflavors can be set if
  using distutils but flavors are not wanted.

  A new USE_PYTHON=optsuffix that will add PYTHON_PKGNAMESUFFIX has been
  added to cope with Python ports that did not have the Python
  PKGNAMEPREFIX but are flavored.

  USES=python now also exports a PY_FLAVOR variable that contains the
  current python flavor.  It can be used in dependency lines when the
  port itself is not python flavored.  For example, deskutils/calibre.

  By default, all the flavors are generated.  To only generate flavors
  for the versions in PYTHON2_DEFAULT and PYTHON3_DEFAULT, define
  BUILD_DEFAULT_PYTHON_FLAVORS in your make.conf.

  In all the ports with Python dependencies, the *_DEPENDS entries MUST
  end with the flavor so that the framework knows which to build/use.
  This is done by appending '@${PY_FLAVOR}' after the origin (or
  @${FLAVOR} if in a Python module with Python flavors, as the content
  will be the same).  For example:

    RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}

PR:		223071
Reviewed by:	portmgr, python
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12464

devel/android-tools-{adb,fastboot}: update to 8.0.0.r24

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r4..android-8.0.0_r24/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r4..android-8.0.0_r24/fastboot

devel/android-tools-adb-devel: update to o.p.4.4534

Changes:	https://android.googlesource.com/platform/system/core/+log/7229576bfed0..612b47630f6f/adb

devel/android-tools-adb-devel: update to o.p.4.4506

Changes:	https://android.googlesource.com/platform/system/core/+log/cfadedb1391f..7229576bfed0/adb