devel/arcanist-lib 20230530

*/*php86*: Sunrise

Please DO NOT use this version in production, it is an early test version.

For upgrade notes please visit:
https://github.com/php/php-src/blob/php-8.6.0alpha1/UPGRADING

Changelog: https://github.com/php/php-src/blob/php-8.6.0alpha1/NEWS

devel/arcanist-lib: Update to 20230530

devel/arcanist-lib: Add missing patch file

devel/arcanist-lib: Cleanup latest patch

Use code from devel/phorgeit-arcanist. Should work on
all supported PHP versions.

devel/arcanist-lib: Fix runtime with php82 and later

Approved by:	portmgr (blanket)

devel/*arcanist*: Improve COMMENT

Reported by:	ziaee
Differential Revision:	https://reviews.freebsd.org/D53566

devel/arcanist-lib: Fix for php 8.3+

devel/arcanist-lib: Ignore with php85

Too many things got deprecated.

devel/arcanist-lib: Fix for PHP 8.4.0RC3 (revisited)

This time including the patch.

Reported by:	cracauer
Differential Revision:	https://reviews.freebsd.org/D47376

devel/arcanist-lib: Fix for PHP 8.4.0RC3

Reported by:	cracauer
Differential Revision:	https://reviews.freebsd.org/D47376

devel/arcanist-lib: Fix plist issue

Leftover file default.pem should have been removed as part of
03b792c59a524

Reported by:	mfechner

devel/arcanist-lib: Clean up port skeleton

devel/arcanist-lib: Drop ca_root_nss dependency.

This was much harder than it needs to be, because Arcanist is dead set
on forcing a CA bundle instead of letting curl pick one or use the OS
native trust store.  Remove the enforced fallback and set CURL_CAINFO
only if a CA bundle was explicitly configured or custom.pem was found
on disk.  Furthermore, if the configured value is a directory, set
CURL_CAPATH instead.

MFH:		2023Q4
Reviewed by:	grembo
Differential Revision:	https://reviews.freebsd.org/D42042

*/*: Remove merged or non-existent USE_PHP directives

- Remove USE_PHP=hash which is available in default php installation of
  all versions of php
  * security/pear-Horde_Crypt_Blowfish: Remove OPTION MHASH
- Remove USE_PHP=json which is available in default php installation of
  all versions of php
  * devel/pear-PHPTAL: Remove OPTION JSON
  * www/ilias: Remove OPTION SCORM2004
- Remove USE_PHP=mssql which is no longer available in php from php80
  and later and has been replaced with sqlsrv module which is Windows
  only
  * www/codeigniter: Remove OPTION MSSQL
  * www/moodle311: Remove OPTION MSSQL
  * www/moodle39: Remove OPTION MSSQL
  * www/moodle40: Remove OPTION MSSQL
  * www/moodle41: Remove OPTION MSSQL
- Remove USE_PHP=openssl which is available in default php installation
  of all versions of php
  * databases/phpmyadmin: Remove OPTION OPENSSL
  * databases/phpmyadmin5: Remove OPTION OPENSSL
  * security/pear-Horde_Crypt_Blowfish: Remove OPTION OPENSSL
  * www/nextcloud: Remove OPTION SSL
  * www/owncloud: Remove OPTION SSL
- Remove USE_PHP=pcre which is available in default php installation of
  all versions of php
  * sysutils/racktables: Remove OPTION PCRE
- Remove USE_PHP=postgresql which should be USE_PHP=pgsql and update
  following ports
  * www/typo3-11
  * www/typo3-12
- Remove USE_PHP=pdf which is no longer available as php module
  * databases/phpmyadmin: Remove OPTION PDF
- Remove USE_PHP=spl which is available in default php installation of
  all versions of php
- Remove USE_PHP=sqlsrv which was never imported into FreeBSD as that is
  Windows only php module
  * www/typo3-11: Remove OPTION SQLSRV
  * www/typo3-12: Remove OPTION SQLSRV
- Bump where DEFAULT OPTIONS are affected

Sponsored by:	Bounce Experts

Approved by:	portmgr(blanket)

devel/arcanist-lib: Suppress certain runtime exceptions

Default configured PHP 8.1+ issues deprecation errors when NULL
strings are passed into various library functions.

In the past, we tried to address those one by one, which feels
a bit like playing Whac-A-Mole.

This patch adds custom error handling for this kind of deprecation
error, so that it is ignored. This should fix this entire class of
errors at least until PHP 9.0 is released, at which point a different
workaround (or real solution is needed). Therefore previous patches
were removed.

devel/arcanist-lib: Handle NULL argument passed to strlen()

Problem description:

- ArcanistDiffWorkflow.php:getDiffOntoTargets() tries to determine the
  current branch name by calling ArcanistGitAPI.php:getBranchName()

- getBranchName() returns NULL when working on a detached HEAD

- getDiffOntoTargets() calls strlen() with the branch name, which now
  fails with a NULL argument.

Approved by:	grembo (maintainer)
Sponsored by:	The FreeBSD Foundation

devel/arcanist-lib: handle 'arc patch' runtime exception

Approved by:	grembo (maintainer)
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D37969

Fix WWW in parent/child ports

Many of the WWW are overwritten later which means the wrong value
is used. This did not happen before where the children were either
 a) just using the pkg-descr from the parents
 b) or had their own separate pkg-descr with custom WWW

Use WWW?= in parents when the child's WWW is different.

Children that use the same WWW as the parent can just inherit it,
i.e., the child WWW can be removed.

Approved by:	portmgr (implicit)

devel/arcanist-lib: Fix `arc patch` on PHP 8.1

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

devel/arcanist-lib: Update to 20220518

This should reduce problems running on PHP 8.1

PR:		264852
Reported by:	fernape@

devel/arcanist-lib: Update to 20211210

This should unbreak running on PHP 8.0 and (at least)
build on PHP 8.1.

PR:		262343
Reported by:	arrowd@

Fix CONFLICTS entries of multiple ports

There have been lots of missing CONFLICTS_INSTALL entries, either
because conflicting ports were added without updating existing ports,
due to name changes of generated packages, due to mis-understanding
the format and semantics of the conflicts entries, or just due to
typoes in package names.

This patch is the result of a comparison of all files contained in
the official packages with each other. This comparison was based on
packages built with default options and may therefore have missed
further conflicts with optionally installed files.

Where possible, version numbers in conflicts entries have been
generalized, some times taking advantage of the fact that a port
cannot conflict with itself (due to logic in bsd.port.mk that
supresses the pattern match result in that case).

A few ports that set the conflicts variables depending on complex
conditions (e.g. port options), have been left unmodified, despite
probably containing outdated package names.

These changes should only affect the installation of locally built
ports, not the package building with poudriere. They should give an
early indication of the install conflict in cases where currently
the pkg command aborts an installation when it detects that an
existing file would be overwritten,

Approved by:	portmgr (implicit)

Mark ports to IGNORE with new php81

Approved by:	portmgr (infrastructure blanket)
Sponsored by:	Bounce Experts

devel/arcanist-lib: Use Mozilla root CA bundle

This fixes problems with Let's Encrypt certificates after
the R3 Let's Encrypt intermediate CA expired.

Arcanist uses its own certificate bundle by default (default.pem),
overriding curl's default, unless curl.cainfo is set explicitly.

The port now replaces this custom bundle with a symlink to Mozilla's
root CA bundle as installed by security/ca_root_nss.

PR: 258824
Reported by: yasu

Clean up some things

- Fix typos
- Remove duplicate variables
- Remove nop variables
- Clean up commented PORTREVISION
- Add missing USES

Reported by:	portscan

devel/arcanist-lib: Require CLI version of php

PR:             255088
Reported by:    Mohammad S. Babaei <info@babaei.net>

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

Update to 20210113

PR:		252638
Reported by:	fluffy

Update to 20200111

Should support PHP8

PR:		221528
Submitted by:	fluffy

Generate bash completion rules on install.

So it won't have to be done by root manually/implicitly.

PR:		252421
Reported by:	0mp

Clean plists.

Update devel/arcanist and devel/phabricator to their latest "versions".

Also, switching to using the date of the commit they are based on
as port version, instead of the date when the port was updated.

Patch paths to php executable, so things like ssh-auth work again without workarounds.

Update arcanist(-lib) and phabricator to the latest stable versions.

PORTVERSIONs are the dates of the latest commits on the respective
stable branches.

Deprecate devel/libphutil, as all of its functionality has
been moved into arcanist and phabricator by upstream and
the library has been fully deprecated.

Ignore libphutil/arcanist/phabricator in portscout, as they're rolling release.

Update libphutil, arcanist and phabricator to the latest stable versions

PORTVERSIONs are the dates of the latest commits on the respective
stable branches.

PR:		238512

devel/arcanist: Split into arcanist-lib and arcanist.

The arcanist port has always conflicted with archivers/arc, but
if the port is installed without the symlink in PREFIX/bin, there
is no issue.

A user expecting to be able to use arcanist in this way can alias
arcanist in their .cshrc or similar and only install the -lib port.

Approved by:	grembo (maintainer)
Differential Revision:	https://reviews.freebsd.org/D19920