devel/lua-luacheck0.25.g20200825

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

devel/lua-luacheck: specify ${LUA_FLAVOR} for lua-argparse dependency

While here, use the more appropriate LUA_REFMODSHAREDIR for describing
dependency location.

devel/lua-luacheck: update to just before the unreleased 0.25.0

The intervening changes are many, with new checks and a switch to luarocks
as upstream. This intermediate version also contains some Lua 5.4 support.
Note that Lua 5.4 attributes are currently parsed, but ignored.

argparse is no longer bundled with luacheck, so we'll grab argparse from
devel/lua-argparse.

The build system in luacheck got removed in favor of just using luarocks.
This is currently incompatible with how ports wants to work, so I've changed
it to the simpler approach that was previously advised to just copy the src/
files over and now installing a script from FILESDIR that matches roughly
what we were ending up with before to get the correct package.path.

Miscellaneous indentation fixes included.

USES=lua gained flavors.

Ports using USES=lua:module or lua:flavors will be flavored.  A range of
supported lua versions can be set using XX-YY (or XX-, or -YY, or simply ZZ)
for ports not supporting all lua versions.

USES=lua sets LUA_FLAVOR that needs to be used on all dependencies of
flavored lua ports, in a similar way as PHP or Python flavors.

PR:		245038
Submitted by:	andrew tao11 riddles org uk
Reviewed by:	mat, kevans, russ haley gmail com
Approved by:	mat (portmgr)
Differential Revision:	https://reviews.freebsd.org/D16494

Drop nop NO_CONFIGURE

Add devel/lua-luacheck, linter and static analyzer for lua

Provides linting and static analysis for Lua 5.1, Lua 5.2, Lua 5.3 and
LuaJIT. A patch was required to allow luacheck and luacheck.lua to be
symlinked into ${PREFIX}/bin, which I have submitted upstream.

Checked with:	portlint
Tested with:	Poudriere (head, amd64)
Tested with:	Poudriere (stable/11, amd64)
Tested with:	Poudriere (11.1-R, i386) [lwhsu]
Tested with:	Poudriere (10.4-R, amd64+i386) [lwhsu]
Reviewed by:	lwhsu
Approved by:	lwhsu (ports)
Differential Revision:	https://reviews.freebsd.org/D14467