editors/with-editor: Update to 3.5.4 Sponsored by: The FreeBSD Foundationd76daf4cee
Port details
editors/with-editor3.5.4
Use the Emacsclient as the $EDITOR of child processes
- Maintainer
- jrm@FreeBSD.org
- Packages
- with-editor 3.5.4
- Upstream
- up to date
- CPE
- none, CVEs only via VuXML
- WWW
- https://github.com/magit/with-editor
- Links
- cgit · VuXML
Unaddressed (0) · The CVE record lists this version as affected, no VuXML entry names the CVE
None. There is no CVE without a VuXML entry for this version.
VuXML only (0) · listed, port not fixed yet
None.
pkg audit reports nothing for this version.Fixed (0)
No VuXML entries for this package.
Commits (85)
editors/with-editor: Update to 3.5.3 Changelog: https://github.com/magit/with-editor/blob/v3.5.3/CHANGELOG#v353----2026-08-01 Sponsored by: The FreeBSD Foundation6006f7f6ab
editors/with-editor: Update to 3.5.1 Event: Halifax Hackathon 202606 Sponsored by: The FreeBSD Foundationafac15e219
editors/with-editor: Update to 3.5.0 Changelog: https://github.com/magit/with-editor/blob/main/CHANGELOG#v350----2026-05-01 Sponsored by: The FreeBSD Foundation328ebb39c7
editors/with-editor: Update to 3.4.9 Also, do not byte-compile Elisp since .elc files are no longer packaged. This means we can remove BUILD_DEPENDS and MAKE_JOBS_UNSAFE. Sponsored by: The FreeBSD Foundationf1af7dff74
Emacs Lisp ports framework: Overhaul This overhaul introduces four key changes to the elisp ports framework: 1. Remove support for packaged byte-compiled elisp. The primary motivation is to remove a large number of flavor-specific packages and to simplify the ports tree. As an example, supporting byte-compiled elisp for devel/tablist required six packages, one for each flavor of editors/emacs and editors/emacs-devel. With over 100 elisp ports and requests for new Emacs flavors, this was unmanageable. 2. Install configuration to integrate with Emacs's native compilation machinery, allowing elisp from ports to be compiled into the standard cache under the user's home directory. This matches the behavior of GNU ELPA packages and generally results in a faster experience. Speedups vary depending on the characteristics of the elisp code, but are often reported to be 2.5 to 5 times faster than byte-compiled code. 3. Perform byte compilation on the target host, but only when native compilation is unavailable. Compilation is initiated when Emacs starts, and the resulting .elc files are cached under the user's home directory. 4. Load all autoload files installed by FreeBSD elisp ports. This mirrors what package.el does for ELPA packages, ensuring that autoloaded functions are available without requiring users to explicitly load each package. Users with elisp packages (*-emacs_*) installed should consult the 2026-04-11 UPDATING entry for instructions on handling the transition. Reviewed by: ashish, Benjamin Jacobs <freebsd@dev.thsi.be>, dinoex, mandree, mce, nobutaka, Pat Maddox <pat@patmaddox.com>, rhurlin Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56001bc45b7ec88
editors/with-editor: Take maintainership Sponsored by: The FreeBSD Foundationf57164689b
editors/with-editor: update to 3.4.8.318076e583
*/*: Return to pool I'll be away from keyboard soon and am not sure if I will return. So return all ports that I currently maintain to pool hoping new volunteers take care of them.f12c037f5a
editors/with-editor: Update to 3.4.7 ChangeLog: https://github.com/magit/with-editor/blob/v3.4.7/CHANGELOGbf47519b45
editors/with-editor: Update to 3.4.6 ChangeLog: https://github.com/magit/with-editor/blob/v3.4.6/CHANGELOG407db5eb96
editors/emacs: Update to 30.2 * Replace '30.1' in Mk/Uses/emacs.mk with '30.2'. * Bump PORTREVISION of dependent ports. ChangLog: https://cgit.git.savannah.gnu.org/cgit/emacs.git/tree/etc/NEWS?h=emacs-30.2 Reviewed by: jrm Differential Revision: https://reviews.freebsd.org/D5190641e3c046e7
editors/with-editor*: Update to 3.4.5 ChangeLog: https://github.com/magit/with-editor/blob/v3.4.5/CHANGELOG97cca1b9f8
editors/with-editor*: Update to 3.4.4 ChangeLog: https://github.com/magit/with-editor/blob/v3.4.4/CHANGELOG371f8a7439
*/*: Chase editors/emacs update Sponsored by: The FreeBSD Foundation12940d868a
editors/with-editor*: Update to 3.4.3 ChangeLog: https://github.com/magit/with-editor/blob/v3.4.3/CHANGELOGcffe696904
editors/{with-editor,with-editor-devel}: Update to 3.4.2
ChangeLog: https://github.com/magit/with-editor/blob/v3.4.2/CHANGELOG62761f7d4feditors/{with-editor,with-editor-devel}: Update to 3.4.1
ChangeLog: https://github.com/magit/with-editor/releases/tag/v3.4.1a902d8ac87Chase major version update of editors/emacs-devel Bump PORTREVISION of most USES=emacs ports after editors/emacs-devel major version increased from 30 to 31. Sponsored by: The FreeBSD Foundationb946d410cc
editors/{with-editor,with-editor-devel}: Update to 3.3.4
Changes: https://github.com/magit/with-editor/compare/v3.3.3...v3.3.49145a81289Chase editors/emacs update to 29.4 - Bump Emacs version in Mk/Uses/emacs.mk to update version-specific paths - Bump PORTREVISION of ports with USES=emacs. This is required for two reasons. Emacs lisp files need to be byte compiled for the new Emacs version, and files installed under, e.g., EMACS_VERSION_SITE_LISPDIR need to be relocated. Reviewed by: ashish, yasu Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D457053213a3f54a
editors/{with-editor,with-editor-devel}: Update to 3.3.3
Changes: https://github.com/magit/with-editor/compare/v3.3.2...v3.3.3 (editors/with-editors)
Changes: https://github.com/magit/with-editor/compare/1b45264...v3.3.3 (editors/with-editors-devel)76582763be*/*: Fix build when PDF option is enabled
When PDF option is enabled PDF file is generated from Texinfo source
file with texi2pdf, and the command is invoked with '--clear'
option. When the command is invoked with the option, however, it
returns non-zero value even if conversion is (or, at least seems to
be) successful. As a result build of ports fails when the option is
enabled. The command returns zero value if it is invoked without the
option. So fix build by patching Makefile of source tree.
While I'm here, replace CONFLICTS in devel/{forge,forge-devel/Makefile
with CONFLICTS_INSTALL as neither of them interfere with build of the
other.67bdba3a9aeditors/with-editor: Mark BROKEN for PDF option Silently fails to build when PDF is enabled Approved by: portmgr (blanket) Sponsored by: Nepustil9d43812b94
Chase editors/emacs update - Bump Emacs version in Mk/Uses/emacs.mk to update version-specific paths - Bump PORTREVISION of ports with USES=emacs. This is required for two reasons. Emacs lisp files need to be byte compiled for the new Emacs version, and files installed under, e.g., EMACS_VERSION_SITE_LISPDIR need to be relocated. Reviewed by: ashish Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D4449226421ac37c
*/*: Chase editors/emacs update - Bump Emacs version in Mk/Uses/emacs.mk to update version-specific paths - Bump PORTREVISION of ports with USES=emacs. This is required for two reasons. Emacs lisp files need to be byte compiled for the new Emacs version, and files installed under, e.g., EMACS_VERSION_SITE_LISPDIR need to be relocated. Reviewed by: ashish Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43615ab463bdca9
editors/with-editor*: Update to 3.3.2 Changes: https://github.com/magit/with-editor/compare/v3.3.1...v3.3.2be5d42f889
editors/with-editor*: Update to 3.3.1 Changes: https://github.com/magit/with-editor/releases/tag/v3.3.188f0d4a12e
editors/emacs: Update to 29.1
* Update Canna patch to the one for Emacs 29.
* Add new options PGTK, SQLITE3, TREESITTER and WEBP. SQLITE3 and
TREESITTER are ON by default. PGTK and WEBP options are excluded
from nox flavor.
* CARGO option doesn't imply XFT but prevents it. It is caused as a
result of adding pure GTK support (PGTK option).
* OTK options doesn't imply XTF any more. It is also caused as a
result of adding pure GTK support.
* Update NATIVECOMP option so it specifies ahead-of-time compilation
via the configure argument.
* Remove "experimental" from NATIVECOMP_DESC.
* Add print/freetype2 and x11-fonts/fontconfig to CAIRO_LIB_DEPENDS
and GTK3_LIB_DEPENDS. Necessary to link emacs binary with shared
libraries.
* When PGTK option is ON and SCROLLBARS is OFF, configure fails as
following
----------------------------------------------------------------------
checking for gnutls >= 2.12.2... yes
checking for jansson >= 2.7... yes
checking for tree-sitter >= 0.20.2... yes
checking for libkqueue... no
checking for library containing kqueue... none required
configure: error: Non-toolkit scroll bars are not implemented for your system
----------------------------------------------------------------------
So add SCROLLBARS to PGTK_IMPLIES to avoid such options setting.
* When MODULES option is OFF and TREESITTER is ON, link error happens
as following.
----------------------------------------------------------------------
cc -o temacs.tmp \
-Demacs -I. -I. -I../lib -I../lib -I/usr/local/include -I/usr/local/include/librsvg-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -pthread -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -D_THREAD_SAFE -I/usr/local/include/libpng16 -I/usr/local/include/libxml2 -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/webp -I/usr/local/include -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -pthread -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -MMD -MF deps/.d -MP -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/p11-kit-1 -I/usr/local/include/cairo -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -D_THREAD_SAFE -Wno-switch -Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes -Wno-unknown-pragmas -Wno-initializer-overrides -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fstack-protector-strong -L/usr/local/lib -L/usr/local/lib \
dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o xsmfns.o xsettings.o dbusbind.o emacs.o keyboard.o macros.o keymap.o sysdep.o bignum.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex-emacs.o undo.o alloc.o pdumper.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o sort.o font.o print.o lread.o syntax.o bytecode.o comp.o process.o gnutls.o callproc.o region-cache.o sound.o timefns.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o lcms.o kqueue.o profiler.o decompress.o thread.o systhread.o sqlite.o treesit.o itree.o xfont.o ftfont.o ftcrfont.o hbfont.o fontset.o fringe.o image.o xgselect.o json.o terminfo.o lastfile.o ../lib/libgnu.a ../oldXMenu/libXMenu11.a -ltiff -ljpeg -L/usr/local/lib -lpng16 -lgif -L/usr/local/lib -lwebpdemux -lwebpdecoder -lSM -lICE -lX11 -lXrender -L/usr/local/lib -lrsvg-2 -lm -lgio-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lintl -lcairo -lrt -L/usr/local/lib -ldbus-1 -lexecinfo -L/usr/local/lib -lXrandr -L/usr/local/lib -lXinerama -L/usr/local/lib -lXfixes -lXext -lXext -L/usr/local/lib -lxml2 -lutil -L/usr/local/lib -lcairo -lncurses -L/usr/local/lib -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lgobject-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lfreetype -L/usr/local/lib -lfontconfig -lfreetype -L/usr/local/lib -lharfbuzz -L/usr/local/lib -lgnutls -lpthread -L/usr/local/lib -llcms2 -llcms2_fast_float -llcms2_threaded -lm -lz -L/usr/local/lib -ljansson -lgmp -L/usr/local/lib -lXi -L/usr/local/lib -ltree-sitter -lsqlite3 -lXcomposite -lXext
ld: error: undefined symbol: dynlib_error
>>> referenced by treesit.c
>>> treesit.o:(treesit_load_language)
>>> referenced by treesit.c
>>> treesit.o:(treesit_load_language)
>>> referenced by treesit.c
>>> treesit.o:(treesit_load_language)
>>> referenced 1 more times
ld: error: undefined symbol: dynlib_sym
>>> referenced by treesit.c
>>> treesit.o:(treesit_load_language)
ld: error: undefined symbol: dynlib_open
>>> referenced by treesit.c
>>> treesit.o:(treesit_load_language)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
----------------------------------------------------------------------
So add MODULES to TREESITTER_IMPLIES to avoid such options setting.
* Bump PORTREVISION of ports that use "USES=emacs".
ChangeLog: https://git.savannah.gnu.org/cgit/emacs.git/tree/etc/NEWS?h=emacs-29.1
Reviewed by: ashish, jrm
Differential Revision: https://reviews.freebsd.org/D41444ba4eb3a50eeditors/with-editor*: Update to 3.3.0 Changes: https://github.com/magit/with-editor/commits/v3.3.086aa23c4fe
*: Bump PORTREVISIONs for math/mpc update to 1.3.18d3e020ed0
Mk/**tex.mk: Convert bsd.tex.mk to USES=tex - Update all the consumers to use USES=tex - USE_TEX=yes is the old way of writing USES=tex which has been removed and replaced in all ports - Almost all of the USE_TEX features remains unchanged - Some consumers had the same variables defined both in the mk infrastructure and also in the ports which have been removed from the ports as those are redundant. In case any of the consumers are failing to build please make sure that the nexessary USES=tex is there. Unlike previous USE_TEX=yes will no longer load the required VARS for tex and related dependencies. Reviewed by: portmgr Approved by: portmgr (blanket)721e5776c9
editors/emacs-devel: Update to 2022-11-28 snapshot Bump PORTREVISION of consumers as EMACS_VER is changed to 30.0.50. Changes: https://github.com/emacs-mirror/emacs/compare/51589f81...7939184fea66012756
editors/emacs: Update to 28.2 * Remove FCITXPATCH option as extra-patch-src_xfns.c can't be applied since 28.1. * Tidy up Makefile with portfmt. * Bump PORTREVISION of consumers. ChangeLog: https://www.gnu.org/software/emacs/news/NEWS.28.2 PR: 266454 Exp-run by: antoine Reviewed by: ashish, jrm Differential Revision: https://reviews.freebsd.org/D36613164249e867
Remove WWW entries moved into port Makefiles Commit b7f05445c00f has added WWW entries to port Makefiles based on WWW: lines in pkg-descr files. This commit removes the WWW: lines of moved-over URLs from these pkg-descr files. Approved by: portmgr (tcberner)fb16dfecae
Add WWW entries to port Makefiles It has been common practice to have one or more URLs at the end of the ports' pkg-descr files, one per line and prefixed with "WWW:". These URLs should point at a project website or other relevant resources. Access to these URLs required processing of the pkg-descr files, and they have often become stale over time. If more than one such URL was present in a pkg-descr file, only the first one was tarnsfered into the port INDEX, but for many ports only the last line did contain the port specific URL to further information. There have been several proposals to make a project URL available as a macro in the ports' Makefiles, over time. This commit implements such a proposal and moves one of the WWW: entries of each pkg-descr file into the respective port's Makefile. A heuristic attempts to identify the most relevant URL in case there is more than one WWW: entry in some pkg-descr file. URLs that are not moved into the Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr files in order to preserve them. There are 1256 ports that had no WWW: entries in pkg-descr files. These ports will not be touched in this commit. The portlint port has been adjusted to expect a WWW entry in each port Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as deprecated. Approved by: portmgr (tcberner)b7f05445c0
editors/with-editor-devel: Add new port Add editors/with-editor-devel, development version of Emacs Lisp library to use the emacsclient as the $$EDITOR of child processes. https://github.com/magit/with-editorac4cee8e12
editors: remove 'Created by' lines A big Thank You to the original contributors of these ports: * Adam Saponara <as@php.net> * Adam Weinberger <adamw@FreeBSD.org> * Akinori MUSHA aka knu <knu@idaemons.org> * Alexey Dokuchaev <danfe@FreeBSD.org> * Andreas Kohout <shanee@augusta.de> * Andrej Zverev <az@inec.ru> * Andrey Zakhvatov * Anton Tornqvist <antont@inbox.lv> * Bill Fumerola <billf@chc-chimes.com> * Bob Eager <bob@eager.cx> * Chris D. Faulhaber <jedgar@fxp.org> * Chris Petrik <chris@officialunix.com> * Christian Brueffer <chris@unixpages.org> * Craig Leres <leres@FreeBSD.org> * Daniel Eischen <deischen@FreeBSD.org> * David O'Brien <obrien@cs.ucdavis.edu> * David Thiel <lx@redundancy.redundancy.org> * Diego Depaoli <trebestie@gmail.com> * Dima Dorfman <dima@unixfreak.org> * Dmitri Goutnik <dg@syrec.org> * Dominic Mitchell * Emanuel Haupt <ehaupt@FreeBSD.org> * Frederic Cambus * Gea-Suan Lin <gslin@gslin.org> * Geoffrey Mainland <mainland@apeiron.net> * Grzegorz Blach <gblach@FreeBSD.org> * Hakisho Nukama <nukama@gmail.com> * James Bailie <jimmy@mammothcheese.ca> * Janos Mohacsi <janos.mohacsi@bsd.hu> * Jason Evans <jasone@FreeBSD.org> * Jean-Yves Lefort <jylefort@brutele.be> * Jille Timmermans (jille@quis.cx) * Joe Marcus Clarke <marcus@FreeBSD.org> * Johannes Meixner <johannes@perceivon.net> * John Merryweather Cooper et al * Jun-ichiro itojun Itoh <itojun@itojun.org> * KIMURA Yasuhiro <yasu@utahime.org> * Kelly Yancey <kbyanc@posi.net> * Kenneth Vestergaard Schmidt <kvs@pil.dk> * Kris Kennaway <kris@FreeBSD.org> * Leif Pedersen <bilbo@devpit.org> * MANTANI Nobutaka <nobutaka@nobutaka.com> * Mark Pulford <mark@kyne.com.au> * Martin Blapp * Matías Pizarro <matias@pizarro.net> * Maxim Sobolev <sobomax@FreeBSD.org> * Michael Johnson <ahze@FreeBSD.org> * Michael Johnson <ahze@ahze.net> * Michael L. Hostbaek (mich@freebsdcluster.org) * Michael Vasilenko <acid@stu.cn.ua> * Miguel Clara <miguelmclara@gmail.com> * Mohammad S. Babaei <info@babaei.net> * Nicola Vitale <nivit@email.it> * Olga Smirnova <mistresssilvara@hotmail.com> * Oliver Lehmann <oliver@FreeBSD.org> * Olivier Cochard-Labbe <olivier@FreeBSD.org> * Olivier Duchateau * Patrick Li <pat@databits.net> * Peter Wemm <peter@FreeBSD.org> * Philippe Lefebvre <nemesis@balistik.net> * Rimvydas Jasinskas <zrj@ef.irc> * Roman Shterenzon <roman@xpert.com> * Satoshi Asami (asami) * Shaun Amott <shaun@FreeBSD.org> * Shigeyuki FUKUSHIMA <shige@FreeBSD.org> * Shigeyuki Fukushima <shige@FreeBSD.org> * Stanislav Sedov <stas@core.310.ru> * Thomas Gellekum <tg@FreeBSD.org> * Vitaly Magerya <vmagerya@gmail.com> * Xin LI <delphij@FreeBSD.org> * Ying-Chieh Liao * Ying-Chieh Liao <ijliao@FreeBSD.org> * Yoichi NAKAYAMA <yoichi@eken.phys.nagoya-u.ac.jp> * alepulver * brett@peloton.physics.montana.edu * buganini@gmail.com * eric * erich@rrnet.com * gahr * gelf * giffunip@asme.org * ijliao * jkh * joerg * joseph@randomnetworks.com * krion * lightside <lightside@gmx.com> * pgf * rch@richard.eu.org * tetsushi NAKAI <nakai@tsl.pe.u-tokyo.ac.jp> * tg * thierry@pompo.net * torstenb@FreeBSD.org * verm With hat: portmgr7cd7a8d850
Emacs ports: Bump PORTREVISION after Emacs 28.1 Reviewed by: ashish Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34781d9dcd9c687
editors/with-editor: Add PDF option and change DOCS option * Add new option PDF. If it is enabled PDF document is built and installed. * Change DOCS option so HTML document is built and installed if it is enabled.6a1cfd2b6f
editors/with-editor: Update to 3.2.0 Changes: https://github.com/magit/with-editor/commits/v3.2.00029b0875f
editors/with-editor: Update to 3.1.1 Changes: https://github.com/magit/with-editor/commits/v3.1.166bda7172f
editors/with-editor: Update to 3.1.0 Changes: https://github.com/magit/with-editor/commits/v3.1.06c5200b096
USES=emacs: Chase package name changes PR: 259259 Differential Revision: https://reviews.freebsd.org/D32613061afcca16
editors/with-editor: Update to 3.0.5 Changes: https://github.com/magit/with-editor/commits/v3.0.5 Approved by: ygy (mentor) Differential Revision: https://reviews.freebsd.org/D32275b071a304f4
*: Chase new major version (29) of editors/emacs-devel Differential Revision: https://reviews.freebsd.org/D32258126e3bb1f1
*/*: Update MAINTAINER address of my ports to that of FreeBSD.org Approved by: meta (mentor) Differential Revision: https://reviews.freebsd.org/D3217010c30f1825
editors/with-editor: Update to 3.0.4. - Pet portclippy. - Reformat with portfmt. ChangeLog: https://github.com/magit/with-editor/commits/v3.0.4 PR: 256160 Approved by: dbaio, garga (mentors, implicit)68c6c90da6
Remove # $FreeBSD$ from Makefiles.305f148f48
editors/emacs: Update to 27.2 This is a bug-fix release with no new features. https://www.gnu.org/software/emacs/news/NEWS.27.2 Reviewed by: ashish Differential Revision: https://reviews.freebsd.org/D277004c42925142