maintainer-feedback? mail/opendmarc: Make MySQL support optional
Open
2026-09-05
Commits (31)
Vladimir Druzenko (vvd) · 1.4.2_4
net/openrsync: Improve port
- Fix warnings from portclippy.
- Adjust whitespaces: allign values in LICENSE* variables, remove/add
several empty lines.
- Remove GNU_CONFIGURE_MANPREFIX.
- Use "${DISTVERSION:S/./-/g}" in GH_TAGNAME instead of hardcoded
version "1-4-2".
- Use ${PORTNAME} instead of "opendmarc" in GH_TAGNAME and USE_RC_SUBR.
PR: 286588
Approved by: Dan Mahoney <freebsd@gushi.org> (maintainer)
databases/p5-DBD-mysql: Fix for MariaDB users
Add a new variable DBD_MYSQL, use that in *_DEPENDS and add mysql to USES
where required. DBD_MYSQL will automatically set the correct DBD dependency.
In cd16748194e2 databases/p5-DBD-mysql was updated to 5.x, in 5.x the
support for MariaDB was removed and only MySQL >= 8.0 is supported.
In the 4.x releases MariaDB is still supported, according to upstream 4.x
will still be supported for a while [1], so use that for now when we detect
that MYSQL_FLAVOUR is set to mariadb. databases/p5-DBD-mysql4 was added in
d95f49cb3b54.
DBD:MariaDB would be another alternative, but migrating to it might need
more analysis than just staying with the 4.x releases of p5-DBD-mysql. This
thread on the amavis-users mailing list has a very good summary [2] from
the author of DBD:MariaDB.
This includes ideas and suggestions from vvd and mat. Thanks!
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277889#c17
[2] https://lists.amavis.org/pipermail/amavis-users/2024-March/006823.html
PR: 275100, 277889
Reviewed by: vvd, mat
Fixes: cd16748194e2
Differential Revision: https://reviews.freebsd.org/D44662
Remove WWW entries moved into port Makefiles
Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.
This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.
Approved by: portmgr (tcberner)
Add WWW entries to port Makefiles
It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.
Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.
There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.
This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.
There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.
The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.
Approved by: portmgr (tcberner)
mail/opendmarc: fix multiple addresses in From vulnerability
- please note that it might only be a partial fix, see
https://github.com/trusteddomainproject/OpenDMARC/pull/48#issuecomment-530375590
PR: 240505
Reported by: protonmail
Approved by: ports-secteam (delphij)
Obtained from: https://github.com/trusteddomainproject/OpenDMARC/pull/48
MFH: 2019Q3
Security: https://protonmail.com/blog/bellingcat-cyberattack-phishing/
- bump MILTER_SOVER to fix linking on FREEBSD-12 - bump PORTREVISION on ports using libmilter - rename WITH_SENDMAIL_PORT to WITH_MILTER_PORT - rename WITH_SENDMAIL_BASE to WITH_MILTER_BASE - rename WITH_SENDMAIL_STATIC_MILTER to WITH_MILTER_STATIC - cleanup ifdefs - fix build on batv-filter with libmilter from ports
mail/opendmarc: update 1.3.1 -> 1.3.2
Feature request #86: Change meaning of "RequiredHeaders" such that
header validity is always checked, but messages are only
rejected on that basis when the flag is set. Based
on a patch from Andreas Schulze.
Feature request #127: Log SPF results when rejecting. Requested
by Patrick Wagner; patch from Andreas Schulze, follow-up
patch from Juri Haberland.
Feature request #138: Inculde policy and disposition information
in an Authentication-Results comment. Based on a patch
from Juri Haberland.
Feature request #139: Include the client host name if known
in failure reports. Suggested by Roland Turner;
patch by Andreas Schulze.
Fix bug #95: Assume IPv6 for SPF operations. Patch from Juri Haberland.
Fix bug #120: Fix control logic around the SPF result.
Reported by Christophe Wolfhugel; patch from Andreas Schulze.
Fix bug #122: Don't skip the HELO milter phase when SPF is enabled.
Reported by Christophe Wolfhugel.
Fix bug #157: Fix logging of implicit authserv-ids. Reported
by Andreas Schulze; patch from Juri Haberland.
Fix bug #158: Log ignored connections. Patch from Andreas Schulze.
Fix bug #160: Fix "SyslogFacility" handling. Patch from
Juri Haberland.
Fix bug #163: Use a larger buffer for the raw MAIL FROM value.
Based on a patch from Andreas Schulze.
Fix bug #174: Trim "!" suffixes from reporting addresses. Problem
noted by Juri Haberland.
Fix bug #186: When reloading the configuration file, the public
suffix list was read in with the wrong comment indicator.
Patch from Federico Omoto.
LIBOPENDMARC: Fix bug #115: Fix type mismatch. Patch from
Sebastian A. Siewior via Scott Kitterman.
LIBOPENDMARC: Fix bug #121: Fix IPv6 CIDR matching in SPF code.
Patch from Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #125: Compile time IPv6 fix. Reported by
Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #131: Fix alignment bug. Patch from
Andreas Schulze.
LIBOPENDMARC: Fix bug #147: Fix stripping of whitespace from
DMARC DNS records. Based on a patch from Job Noorman.
LIBOPENDMARC: Fix bug #149: Apply "sp" setting, if present and
applicable. Patch from Petr Novak.
LIBOPENDMARC: Fix bug #154: Fix "rf" and "fo" processing logic.
LIBOPENDMARC: Fix bug #156: Fix variable name. Patch by
Andreas Schulze.
LIBOPENDMARC: Fix bug #165: Fix logic in checking which SPF
identifier was used. Patches from Marco Favero and
Juri Haberland.
LIBOPENDMARC: Fix bug #167: Don't return "fail" when we should
return "none". Patch from Marco Favero.
REPORTS: Fix bug #134: Handle SMTP errors correctly. Patch from
Andreas Schulze.
REPORTS: Fix bug #141: Set the HELO parameter correctly.
Reported by Alan Smith; patch from Andreas Schulze.
REPORTS: Fix bug #143: Fix logic in table truncation.
Reported by Wayne Andersen; patch from Juri Haberland.
REPORTS: Fix bug #162: Always report "sp" in aggregate reports.
Patch from Juri Haberland.
REPORTS: Fix bug #166: Fix report start/end time logic.
Patch from Juri Haberland.
REPORTS: Fix bug #188: Don't delete inputs too early in
opendmarc-reports. Patch from Juri Haberland.
TOOLS: Fix bug #161: "Forensic" reports were renamed "Failure"
reports. Patch from Andreas Schulze.
TOOLS: Fix bug #164: Handle IPv6 test addresses. Reported by
Andreas Schulze; patch from Juri Haberland.
DOCS: Patch #189: Replace the DMARC RFC with an HTML page
referencing the relevant specs, since Debian doesn't
consider RFCs to be "free". Patch from Scott Kitterman
via Juri Haberland.
PR: 220902
Submitted by: Dan Mahoney <freebsd@gushi.org> (maintainer), Lukasz Wasikowski <lukasz@wasikowski.net>
(1) Add USES perl5 and add RUN_DEPENDS for perl modules needed by the various perl scripts installed by this port
(2) Use ${PORTSDIR}/mail/sendmail/bsd.milter.mk to link against
libmilter installed by the mail/sendmail port when
WITH_SENDMAIL_PORT=yes is set in /etc/make.conf or the base
libmilter if WITH_SENDMAIL_BASE=yes
PR: 202374 (1)
Submitted by: freebsd-ports@dan.me.uk (1) matthew (2)
Reviewed by: pi (1)
Approved by: maintainer timeout (>14days)
1) Makes opendmarc rc script more local: sockets friendly (create directory with needed permissions, start/stop cleanups).
2) Move pidfile to newly created /var/run/opendmarc by default.
This directory is perfectly suitable and needed mainly for local: sockets,
but to not violate POLA socket still remains as "inet:8893@localhost".
Approved by: maintainer timeout
mail/opendmarc: Add libspf2 as a run-time (library) dependency
libsfp2 is a build and run-time dependency for opendmarc.
Currently libspf2 is declared a BUILD_DEPENDS, which results in the
libspf2 package being removed by portmaster or pkg as an unecessary
package when using -s argument or autoremove command respectively.
This change correctly declares libspf2 as a LIB_DEPENDS, resulting
in both build and run-time dependency registration.
While I'm here:
- Convert MSPF conditional to an option helper
- Group and sort USE{S} entries
- Whitespace align OPTIONS
- Tweak SPF_DESC to match ./configure output for the option
- Sort pkg-plist
PR: 204050
Submitted by: Douglas <douglas douglasthrift net>
Approved by: portmgr (blanket)
MFH: 2015Q4
MASTER_SITES cleanup.
- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.
While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.
Also, replace some EXTRACT_SUFX occurences with USES=tar:*.
Checked by: make fetch-urlall-list
With hat: portmgr
Sponsored by: Absolight
five milter ports: Add or improve support on systems missing sendmail
In some cases no-sendmail support was in place but missing CFLAGS or
LDFLAGS, but in others it needed to be added. Problems found as a result
of DragonFly removing sendmail from base.
Approved by: just fix it.
Update to version 1.3.1, Maintainer change to Dan Mahoney <danm@prime.gushi.org>
This is mainly a bug fix release, but it does contain one important new
feature. Upgrade is recommended.
The full RELEASE_NOTES for this version, showing changes since the last
release:
1.3.1 2015/02/23
Fix bug #97: Add ability to change envelope sender, client IP
address, client hostname, and HELO value used in test
mode, via environment variables. This can be turned
into something more formal in a later release. Suggested
by Andreas Schulze.
Fix bug #102: Don't lose SPF results and output the "-1" default.
Reported by Kurt Roeckx.
Fix bug #103: Fix IgnoreAuthenticatedClients by requesting the
right macro value from the MTA.
Fix bug #113: Remove "TemporaryDirectory" (unused). Patch from
Andreas Schulze.
LIBOPENDMARC: Fix bug #104: Include <sys/param.h> and <resolv.h>
in <opendmarc/dmarc.h> so that MAXPATHLEN and MAXNS get
defined consistently. Reported by Frank J. Lhota.
LIBOPENDMARC: Fix bug #105: Get the h_errno definition from
<netdb.h> rather than declaring it. Problem noted
by Frank J. Lhota.
LIBOPENDMARC: Fix bug #106: Clean up issues with the types passed
to opendmarc_policy_library_dns_hook(). Noted by
Frank J. Lhota.
DOCS: Fix bug #99: Update list of constraints on
opendmarc_policy_fetch_alignment(). Reported by
Frank J. Lhota.
REPORTS: Fix bug #108: Handle malformed mailto URIs in DMARC
records (e.g., just "mailto:"). Reported by Andreas Schulze.
REPORTS: Fix bug #110: Support SQL backend selection in
opendmarc-expire. Reported by Mark Reidenbach.
PR: 198502
Submitted by: Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer)
mail/opendmarc: 1.2.0 -> 1.3.0
1.3.0 2014/07/31
Integrated SPF checking is now available through the new
SPFSelfValidate and SPFIgnoreResults settings.
Feature request #79: Optionally ignore clients that authenticated
using SMTP AUTH.
Fix bug #60, part II: Default AuthservID to the name provided by the
MTA, not the local host name, which is consistent with what
OpenDKIM does. Suggested by Robbert Klarenbeek.
Fix bug #72: Don't crash when From fields are absent. Patch from
Andreas Schulze.
Fix bug #74: Change "Forensic" to "Failure" just about everywhere
to match the language now being used in the base DMARC
draft. Note that this also changes some names in the
configuration file.
Fix bug #75: Correct typo in MIME of forensic reports. Reported by
Julian Mehnle.
Fix bug #76: Repair damage with respect to Authentication-Results
header field selection. Reported by Todd Lyons.
Fix bug #77: Request quarantine from the MTA during option
negotiation. Reported by Richard Platel.
Fix bug #78: Add missing newline in forensic report header.
Fix bug #90: Make "--with-sql-backend" without any value do the
right thing. Reported by Scott Kitterman.
Fix bug #93: Honor size limits in URIs. Patch from Tomki Camp.
Make "smime" and "rrvs" legal Authentication-Results methods.
Provide better logging when pclose() for a forensic report returns
non-zero. Problem noted by Michael Nausch.
Add configuration support for internal SPF checks. Includes hooks in
the milter to check that SPF is configured to do so.
This can use a private SPF implementation or libspf2.
Fix strlcat() and strlcpy() support for Debian. Patch from Scott
Kitterman.
REPORTS: Feature request #80: Generate aggregate reports on UTC
day boundaries. Requested by Tomki Camp.
REPORTS: Feature request #84: Optionally expire old data from
lower-growth tables. Requested by Christoph Steindl.
REPORTS: Fix bug #70: Fix date range generation in reports. Patch
from Karol Augustin.
REPORTS: Fix bug #82: Fix recording of report timestamp to avoid lost
records. Reported by Christoph Steindl.
REPORTS: Fix bug #83: When expiring data, truncate the signatures table
if all messages were expired. Reported by Christoph Steindl.
REPORTS: Fix bug #85: Report subdomain policy. Patch from
Christoph Steindl.
LIBOPENDMARC: Fix bug #71: Fix "rua" extraction from DMARC records
Problem noted by Karol Augustin.
LIBOPENDMARC: Added support for milter to perform own spf checks.
Three new files: opendmarc_spf.c, opendmard_spf_dns.c and
test/test_spf.cl, allow integrated SPF support. Support for
use of libspf2 is also provided.
PR: 192311
Submitted by: jaap@NLnetLabs.nl (maintainer)
OpenDMARC is an open source implementation of Domain-based Message Authentication, Reporting & Conformance, or DMARC. It builds on the successes of technologies such as DomainKeys Identified Mail (DKIM) and the Sender Policy Framework (SPF) to create an infrastructure that enforces policy on domain names that are visible to end users, and creates a feedback framework for identifying and tracking f
It includes a library for handling DMARC record parsing,
a database schema and tools for aggregating and processing transaction
history to produce DMARC reports, and a filter that ties it all together
with an MTA using the milter protocol.
WWW: http://www.trusteddomain.org/opendmarc.html
PR: ports/177486
Submitted by: Jaap Akkerhuis <jaap@NLnetLabs.nl>