multimedia/libx264 0.165.3223

multimedia/x264: fix build on powerpc64*

1. Properly define macros to fix build.
2. Enable VSX on powerpc64le and on powerpc64 if it's available.

multimedia/*x264: Update to 0.165.3223 and transfer maintainership

* Switch to GStreamer's meson branch as it simplifies builds and is
  faster
* Transfer maintainership to multimedia
* Remove DEBUG, GPAC, OPENCL and PGO options
  By switching to Meson we can utilize the framework for debug builds
  GPAC is broken upstream
  OPENCL (lookahead) has very little advantage now that core count for
  CPUs are much higher than a decade ago and with x264's limited
  parallelization. It's also much simplier than x264's other code paths.
  PGO pulls in GCC with no to little benefit
* Add LTO and OPTIMIZED_CFLAGS options
  Available only on aarch64 and amd64, enabled by default

Reviewed by:	bofh (previous iteration and discussed on Matrix)

multimedia/libx264: fix build on powerpc64le on 15

cc: error: unsupported option '-mabi=' for target 'powerpc64le-unknown-freebsd15.0'

multimedia/libx264: BROKEN on powerpc64le 15

endian test failed

Reported by:	portsfallout

multimedia: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  Aaron LI <aly@aaronly.me>
  *  Alexander Botero-Lowry <alexbl@FreeBSD.org>
  *  Alexander Logvinov <ports@logvinov.com>
  *  Alexey Dokuchaev <danfe@FreeBSD.org>
  *  Anders Nordby <anders@FreeBSD.org>
  *  Andrew Pantyukhin <infofarmer@FreeBSD.org>
  *  Andrew Thompson <andy@fud.org.nz>
  *  Andrew Thompson <thompsa@FreeBSD.org>
  *  Angel Carpintero <ack@telefonica.net>
  *  Anish Mistry (with help from mean)
  *  Anonymous <swell.k@gmail.com>
  *  Ashish SHUKLA <ashish@FreeBSD.org>
  *  Ashish Shukla <wahjava@gmail.com>
  *  Ben Woods <woodsb02@FreeBSD.org>
  *  Brian Somers <brian@FreeBSD.org>
  *  Bruce M Simpson <bms@FreeBSD.org>
  *  Byung-Hee HWANG <bh@izb.knu.ac.kr>
  *  Charlie Kester <corky1951@comcast.net>
  *  Chess Griffin <chess@chessgriffin.com>
  *  Chris Piazza <cpiazza@FreeBSD.org>
  *  Christopher Key <cjk32@cam.ac.uk>
  *  Chuck Hein <chein@FreeBSD.org> & Jim Overholt <overholt@isdw.net>
  *  Daniel Morante <daniel@morante.net>
  *  Diego Depaoli <trebestie@gmail.com> and Yinghong Liu <relaxbsd@gmail.com>
  *  Dierk Sacher <dierk@blaxxtarz.de>
  *  Dreamcat4 <dreamcat4@gmail.com>
  *  Earl Gay <earl@eeg3.net>
  *  Ed Schouten <ed@FreeBSD.org>
  *  Edwin Groothuis <edwin@mavetju.org>
  *  Emanuel Haupt <ehaupt@FreeBSD.org>
  *  Felix Palmen <felix@palmen-it.de>
  *  Franz Bettag <franz@bett.ag>
  *  FreeBSD GNOME Team <gnome@freebsd.org>
  *  Gea-Suan Lin <gslin@gslin.org>
  *  George Reid <greid@ukug.uk.freebsd.org>
  *  Grzegorz Blach <gblach@FreeBSD.org>
  *  Gustau Perez <gustau.perez@gmail.com>
  *  Harold Gutch <logix@foobar.franken.de>
  *  Heiner <h.eichmann@gmx.de>
  *  Heiner Eichmann <h.eichmann@gmx.de>
  *  Hendrik Scholz <hendrik@scholz.net>
  *  Herbert J. Skuhra <h.skuhra@gmail.com>
  *  Herve Quiroz <hq@FreeBSD.org>
  *  Holger Lamm
  *  J.R. Oldroyd <fbsd@opal.com>
  *  Jason Harmening <jason.harmening@gmail.com>
  *  Jille Timmermans (jille@quis.cx)
  *  Juergen Lock <nox@FreeBSD.org>
  *  Juergen Lock <nox@jelal.kn-bremen.de>
  *  KalleDK <plexmaintainer@k-moeller.dk>
  *  Koop Mast <kwm@FreeBSD.org>
  *  Koop Mast <kwm@rainbow-runner.nl>
  *  Kozlov Sergey <kozlov.sergey.404@gmail.com>
  *  Kris Moore
  *  Kuan-Chung Chiu <buganini@gmail.com>
  *  Lars Eggert <lars.eggert@gmx.net>
  *  Leinier Cruz Salfran <salfrancl@yahoo.es>
  *  MANTANI Nobutaka <nobutaka@nobutaka.com>
  *  Manuel Creach <manuel.creach@icloud.com>
  *  Marc van Woerkom <3d@FreeBSD.org>
  *  Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
  *  Mark Felder <feld@FreeBSD.org>
  *  Martin Matuska <mm@FreeBSD.org>
  *  Martin Neubauer <m.ne@gmx.net>
  *  Martin Wilke <miwi@FreeBSD.org>
  *  Michael Johnson <ahze@FreeBSD.org>
  *  Michael Johnson <ahze@ahze.net>
  *  Michael Nottebrock <michaelnottebrock@gmx.net>
  *  Michael Nottebrock <michaelnottebrock@gmx.net> et al
  *  Mina Naguib <webmaster@topfx.com>
  *  Mykola Dzham <i@levsha.me>
  *  Naram Qashat <cyberbotx@cyberbotx.com>
  *  Olivier Cochard-Labbe <olivier@FreeBSD.org>
  *  Pascal Vizeli <pvizeli@yahoo.de>
  *  Pav Lucistnik <pav@FreeBSD.org>
  *  Pawel Pekala <pawel@FreeBSD.org>
  *  Petar Zhivkov Petrov <pesho.petrov@gmail.com>
  *  Phil Oleson
  *  Phil Oleson <oz@nixil.net>
  *  Piotr Kubaj <pkubaj@anongoth.pl>
  *  Po-Chuan Hsieh <sunpoet@FreeBSD.org>
  *  Raaf <freebsd@luna.afraid.org>
  *  Randall Hopper <aa8vb@nc.rr.com>
  *  Rodrigo OSORIO <rodrigo@FreeBSD.org>
  *  Rozhuk Ivan 2018 <rozhuk.im@gmail.com>
  *  Rozhuk Ivan <rozhuk.im@gmail.com>
  *  Rozhuk Ivan rozhuk.im@gmail.com
  *  Rusmir Dusko <nemysis@FreeBSD.org>
  *  Stacey Son <mythdev@son.org>, Ari Maniatis <ari@ish.com.au>
  *  Steve Wills <steve@mouf.net>
  *  Steve Wills <swills@FreeBSD.org>
  *  Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
  *  Sylvio Cesar <sylvio@FreeBSD.org>
  *  Thierry Thomas <thierry@pompo.net>
  *  Thomas E. Zander
  *  Thomas E. Zander with help from Vladimir Kushnir
  *  Vladimir Kondratiev <wulf@mail.mipt.ru>
  *  William Grzybowski <wg@FreeBSD.org>
  *  William Grzybowski <william88@gmail.com>
  *  Yi-Hsuan Hsin <mhsin@mhsin.org>
  *  Zastupov Stepan [RedChrom] <redchrom@mail.ru>
  *  adamw
  *  alex
  *  arved
  *  erich@FreeBSD.org
  *  freebsd-ports@evilcode.net
  *  giffunip@asme.org
  *  ijliao
  *  kamikaze@bsdforen.de
  *  michael johnson <ahze@ahze.net>
  *  mikael.urankar@gmail.com
  *  mm
  *  nox@FreeBSD.org
  *  osa
  *  pb@FreeBSD.org
  *  piero
  *  se@FreeBSD.org
  *  sumikawa

With hat:	portmgr

multimedia/libx264: fix build on riscv64

ld: error: relocation R_RISCV_HI20 cannot be used against symbol __stack_chk_guard; recompile with -fPIC
>>> defined in /lib/libc.so.7
>>> referenced by osdep.c
>>>               common/osdep.o:(x264_mdate)

Remove # $FreeBSD$ from Makefiles.

multimedia/x264: update to 0.161.3020

Changes:	https://code.videolan.org/videolan/x264/compare/cde9a93...d198931
ABI:		https://abi-laboratory.pro/tracker/timeline/x264/

multimedia/x264: update to 0.159.2999

Changes:	https://code.videolan.org/videolan/x264/compare/1771b55...296494a4
ABI:		https://abi-laboratory.pro/tracker/timeline/x264/
MFH:		2020Q2 (minor stability fixes)

multimedia/{lib,}x264: return to building with clang on powerpc64 elfv2

Head r359981 and r359994 reverted commits that caused clang to run in infinite loop, allocating all available memory and crashing the system.

multimedia/libx264: unbreak on arm* with LLD

ld: error: can't create dynamic relocation R_ARM_ABS32 against local symbol in readonly segment; recompile object files with -fPIC or pass '-Wl,-z,notext' to allow text relocations in the output
>>> defined in common/arm/mc-a-8.o
>>> referenced by common/arm/mc-a-8.o:(memcpy_table)

Hoist LDFLAGS_${ARCH} logic into bsd.port.mk

Approved by:	portmgr (bapt)
Sponsored by:	The FreeBSD Foundation

multimedia/libx264: add -znotext to LDFLAGS on i386, for lld

Example error:
/usr/bin/ld: error: can't create dynamic relocation R_386_PC32 against
    symbol: gettimeofday in readonly segment; recompile object files
    with -fPIC

This port links some non-PIC code, which fails with lld as it defaults
to disallowing relocations against read-only segments.  For i386 we can
just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's
existing default.

PR:		214864, 230214
Reviewed by:	koobs
Approved by:	koobs
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D17201

Revert r479024 due to build breakage

PR:             230214

multimedia/libx264: set LLD_UNSAFE for i386 and armv7

libx264 has relocations against readonly segment(s) and lld exits with
an error suggesting recompiling with -fPIC.  As this may introduce a
performance impact, for now just fall back to GNU ld.bfd.

PR:		230214
Approved by:	koobs (maintainer)
MFH:		2018Q3

multimedia/x264: update to 0.155.2917

- HI10P is always built after https://git.videolan.org/?p=x264.git;a=commitdiff;h=71ed44c73124

Changes:	https://git.videolan.org/?p=x264.git;a=shortlog;h=0a84d986e7020f8344f00752e3600b9769cc1e85
ABI:		https://abi-laboratory.pro/tracker/timeline/x264/

multimedia/{lib,}x264: update to 0.152.2854

Changes:	https://git.videolan.org/?p=x264.git;a=shortlog;h=e9a5903edf8ca59ef20e6f4894c196f135af735e

multimedia/x264: r445837 forgot to move option helpers

PR:		220694
Approved by:	portmgr blanket
MFH:		2017Q3
Differential Revision:	https://reviews.freebsd.org/D11566

multimedia/x264: enable FFMS, LAVF, SWSCALE by default

Without FFmpeg-based demuxers x264 CLI can only read raw formats as
source. So, enable more options to allow the binary package not only
write but also read mp4/mkv.

PR:		220694
Approved by:	koobs (maintainer)
MFH:		2017Q3 (usability improvement)
Differential Revision:	https://reviews.freebsd.org/D11566

multimedia/libx264: yasm is only used on x86, other archs use GNU as

PR:		220694
Approved by:	koobs (maintainer)
MFH:		2017Q3 (minor build optimization)
Differential Revision:	https://reviews.freebsd.org/D11566

multimedia/x264: yasm is only used by libx264, so move ASM option there

PR:		220694
Approved by:	koobs (maintainer)
MFH:		2017Q3 (minor build optimization)
Differential Revision:	https://reviews.freebsd.org/D11566

multimedia/libx264: clarify slave helper from r413179

Differential Revision:	https://reviews.freebsd.org/D7958
Requested by:	koobs (maintainer)

multimedia/x264: switch to _ENABLE option helper

Many opposite switches are not available, so with default options
selected this change incurs the following warnings.

  multimedia/libx264:
    Unknown option --enable-asm, ignored
    Unknown option --disable-debug, ignored
    Unknown option --enable-opencl, ignored

  multimedia/x264:
    Unknown option --enable-asm, ignored
    Unknown option --disable-debug, ignored
    Unknown option --enable-lsmash, ignored

Differential Revision:	https://reviews.freebsd.org/D7958
Requested by:	koobs (maintainer)

bsd.options.desc.mk: add common OPENCL option description

Differential Revision:	https://reviews.freebsd.org/D7958

multimedia/x264: update to 0.148.2708

Changes:	https://git.videolan.org/?p=x264.git;a=shortlog;h=86b71982e131eaa70125f8d0e725fcade9c4c677
Differential Revision:	https://reviews.freebsd.org/D7958
Approved by:	koobs (maintainer)

multimedia/x264: add OPENCL option, enabled by default

Before OpenCL can be used for lookahead install at least one
implementation: devel/freeocl, devel/pocl, lang/beignet or lang/clover.

  $ x264 --fullhelp | fgrep opencl
	--opencl                Enable use of OpenCL
	--opencl-clbin <string> Specify path of compiled OpenCL kernel cache
	--opencl-device <integer> Specify OpenCL device ordinal

where the options also work in other apps e.g.,

  $ ffmpeg -i <input-file> -codec:v libx264 -x264opts opencl:opencl-device=1 <output-file>
  $ mpv --ovc libx264 --ovcopts-add x264opts=opencl:opencl-device=1 -o <output-file> <input-file>

Differential Revision:	https://reviews.freebsd.org/D7958
Approved by:	koobs (maintainer)

multimedia/x264: don't require SSE on i386 with ASM=on (default)

Remove "-march=i686 -mfpmath=sse -msse" and "-msse2" on later versions
when building C files. This doesn't affect hand-written assembly which
relies on CPUID but may pessimize compiler (around 2.3 % on Skylake).

Differential Revision:	https://reviews.freebsd.org/D7958
Approved by:	koobs (maintainer)

multimedia/x264: add FFMS and LSMASH options

Switch to LSMASH by default to follow vendor configure behavior.

Approved by:	koobs (maintainer, via private mail)
Differential Revision:	https://reviews.freebsd.org/D5861

multimedia/{,lib}x264: modernize

- Convert to option helpers
- Convert to USES=localbase + respect CPPFLAGS
- Convert to USES=shebangfix (can be zsh->bash symlink)
- Simplify SLAVE_PORT conditionals into ?=, += and !target()
- Drop unnecessary `cd` before PGO sample
- Drop no longer necessary .include <bsd.port.options.mk>

Approved by:	koobs (maintainer, via private mail)
Differential Revision:	https://reviews.freebsd.org/D5862

multimedia/libx264: drop unused pkg-descr

$ make -V DESCR
/usr/ports/multimedia/libx264/../x264/pkg-descr

Approved by:	portmgr blanket

multimedia/x264: make options actually affect dependencies

Approved by:	koobs (maintainer, via private mail)
Differential Revision:	https://reviews.freebsd.org/D5860

multimedia/libx264: Move libx264 stdin.h patch to x264 port

Move the libx264 patch for stdint.h handling on FreeBSD to the multimedia/x264
port, as FILESDIR is inherited from there, thus causing the patch not to be
applied.

Reported by:		kwm
Reviewed by:		kwm
Tested by:		kwm
Differential Revision:	https://reviews.freebsd.org/D3168

multimedia/{lib}x264: Fix distinfo's

Delete distinfo from libx264 since it is s now subordinate to the x264 port.

Also correctly update distinfo for x264, including the example.y4m.bz2 video
file for profile guided optimization (OPTION: PGO).

PR:		201260
Reported by:	Ajtim <lumiwa gmail com> (via email)

multimedia/{lib}x264: Update to 0.144.2533 and major refactor

- Update to 0.144.2533 (from upstream stable branch) [1]
- Switch x264 and libx264 ports to master/slave ports respectively
- Bump PORTREVISION for dependent ports as the shared library version
  has changed.

multimedia/x264:

- Clean up and update "updating instructions" in Makefile header
- Tweak COMMENT
- Only LIB_DEPENDS on libx264 and add PLIST_FILES if this isn't the
  libx264 port.
- Allow COMMENT, USES, OPTIONS_*, CONFIGURE_ARGS to be overriden in
  libx264 port.
- Place common configure arguments in a CONFIGURE_COMMON_ARGS variable
  to make overriding values without duplication easier.
- Use --prefix configure argument over post-patch replacements
- Enable stripping of binaries and libraries if DEBUG is off. Remove
  post-install target STRIP_CMD accordingly.

- Delete patch-Makefile in favour of patching WRKSRC/configure to
  identify amd64, arm64 and mipsn32. powerpc and powerpc64 are now
  covered upstream without needing patches.

- Patch out a bogus compiler argument check (cc_check) that results
  in -Wno-maybe-uninitialized being added to CFLAGS causing causes
  warnings when clang is cc. The cc_check function checks for basename
  $CC to identify compiler type (icl, clang, gcc, etc).

multimedia/libx264:

- Remove all Makefile entries that are duplicated or common and found
  in the master port (x264).
- Set lib as the PKGNAMEPREFIX
- Tweak COMMENT
- Delete upstreamed ARM patches [1]
- Delete all but one patch, as they duplicate those in x264.
- Dont remove pkgconfig/libdata directory

Changes:

  https://git.videolan.org/?p=x264.git;a=shortlog;h=refs/heads/stable

Based on:

PR:		201260 [1]
Submitted by:	Andrey Cherkashin <andoriyu gmail com> [1]

Our stdint.h is a symlink to sys/stdint.h so we need to teach x264 the header guard of the sys/stdint.h file. Otherwise compiling software with the x264.h header will generate a warning about the mismatch header guard.

Approved by:	maintainer (koobs@)
Differential Revision:	https://reviews.freebsd.org/D2863

multimedia category: Remove $PTHREAD_LIBS

approved by:	PTHREAD blanket

multimedia/{lib}x264: Update minimum yasm version

Update the minimum version of yasm required in BUILD_DEPENDS.

PR:		196991
Submitted by:	takefu airport.fm

Pull in upstream commits to our libx264 to deal with the clang 3.5 -integrated-as defaults for ARMv6 compilation.

Handling for koobs@ while he's on vacation.

PR:		196591
Submitted by:	mikael.urankar@gmail.com
Approved by:	mentor (implicit)

multimedia/{lib}x264: Fix build on ARMv6

- Fix build for missing symbols on ARMv6 [1]
- Backport upstream 9463ec00 to fix default AS on ARM [2]
- Remove unecessary WRKSRC override (x264)
- Whitespace alignment

[2] http://git.videolan.org/?p=x264.git;a=patch;h=9463ec

PR:		196033 [1]
Submitted by:	Mikael Urandar <mikael.urankar at gmail com> [1]
Tested by:	sbruno

multimedia/libx264: Fix PGO/GCC options

- Revert options helpers for PGO and GCC .. *shakes fist*. We end up
  setting USE_GCC=yes yes otherwise, and that's not valid.
- libx264 and x264 share the same distfiles, use the same DIST_SUBDIR

multimedia/libx264: Fix spaces to tab

multimedia/libx264: Merry Modernized Port Christmas

- Update COMMENT (library only)
- Add LICENSE_FILE
- Use pathfix for pkgconfig
- Remove unecessary WRKSRC override
- Use OPTIONS helpers
- Restore PGO option to OPTIONS_DEFINE
- Don't disable CLI so PGO can run. Remove it in post-install:
- Whitespace alignment
- Sort OPTIONS
- Remove -fstack-protector conditional (framework handles this now)
- Strip shared library

multimedia/x264: General overhaul

- Split x264 into two ports: the CLI application (x264), and the library
  (libx264). This will allow x264 to use lavf and friends from ffmpeg for
  decoding and demuxing while preventing a circular dependency between the
  two: x264 can depend on ffmpeg, but ffmpeg will depend on libx264 rather
  than x264.
- Add the LAVF option to the CLI port, making the dependency on ffmpeg
  optional.
- Update to 0.142.2455.
- Amend fixes to local patches so that they can apply to the new upstream
  files.
- Provide the git revision and other version information to the build
  environment, allowing the CLI binary to display this information (like the
  Windows builds).
- Remove unsupported build options (X11_OUTPUT).
- Ensure that the library and CLI ports each have the appropriate options.
- Add notes for future contributors who wish to update the ports.
- Bump PORTREVISION for all dependent ports.

PR:           187805
Differential Revision:	https://reviews.freebsd.org/D1159
Submitted by: Andrew Berg <aberg010@my.hennepintech.edu>
Approved by:  koobs (maintainer, mentor)