net-p2p/transmission-cli

net-p2p/transmission: Update 3.00 -> 4.0.4 & modernize port

This turns previous slave-ports net-p2p/transmission-{cli,daemon,gtk,qt,utils}
and www/transmission-web into flavours of net-p2p/transmission.

What's new in 4.0.4 (vis-a-vis 3.00)
* Resource Efficiency: code profiled and improved
* Code Modernization: standardization on C++ tools
* Support for BitTorrent v2 torrents & hybrid torrents
* New web client
* Lots of bug fixes

Changelog: https://github.com/transmission/transmission/releases/tag/4.0.4

PR:		269504
Reported by:	dutchman01@quicknet.nl
Approved by:	rigoletto, tcberner (maintainer timeout)
Reviewed By:	fcharlier_ploup.net
Differential Revision: https://reviews.freebsd.org/D40910

net-p2p/transmission: Fix build after the libutp changes.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

devel/cmake: Update to 3.23.0

Update to 3.23.0.
Fix pkg-plist: using the default share/man location

Release Notes:
  https://cmake.org/cmake/help/v3.23/release/3.23.html

PR:		262886
Exp-run by:	antoine

net-p2p/transmission-cli: Fix CPE information

Approved by:    portmgr (blanket)

net-p2p/transmission-*: Fix 'IPv4 DHT announce failed' flooding syslog.

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

net-p2p/transmission-qt: install pixmaps.

- touch net-p2p/transmission-cli

PR:		254372
Submitted by:	Tomasz Kowalczyk <kowalczt.fbsd@gmail.com>

net-p2p/transmission-*: build without debug symbols.

PR:		248326
Submitted by:	ondra@bimovi.cz

net-p2p/transmission: Bring all variants to the latest changes.

- this is supposedly to be the actual 3.00 release

Reported by:	lev

net-p2p/transmission: Allow all variants to be installed concurrently

- split utils in a separated port

PR:		246272
Differential Revision:	https://reviews.freebsd.org/D24851

net-p2p/transmission: Fix build.

- upstream modified the v3.00 code without noticing,
  forcing the re-creation of the distinfo file.

- GH_TAGNAME is temporarily set to avoid new surprises.

net-p2p/transmission: Update to 3.00

- net-p2p/transmission-cli
- net-p2p/transmission-daemon
- net-p2p/transmission-gtk
- net-p2p/transmission-qt
- www/transmission-web

Differential Revision:	D18995

net-p2p/transmission-cli: Drop defunct WOLFSSL option.

- drop LITE_CONFIGURE_ENABLE, a remnant before switching to cmake

PR:		241095
Submitted by:	tobik
Approved by:	tcberner (mentor)

net-p2p/transmission-gtk: Fix .desktop file when NLS disabled.

When the NLS option is disabled the installed transmission-gtk.desktop file
contains fields that start with and underscore, like _Name instead of Name.
When the NLS option is enabled these are replaced by translations.  The attached
patch adds a simple sed command that removes the underscores when NLS is
disabled.

PR:		240125
Submitted by:	tijl
Approved by:	tcberner (mentor)

devel/libevent2: update to 2.1.11

Changes:	https://github.com/libevent/libevent/releases/tag/release-2.1.11-stable
ABI:		https://abi-laboratory.pro/tracker/timeline/libevent/
PR:		239599
Reported by:	GitHub (watch releases)
Approved by:	zeising (maintainer)
MFH:		2019Q3 (maybe security, partially restores 2.1.8 ABI)
Differential Revision:	https://reviews.freebsd.org/D21133

net-p2p/transmission-cli: revert the previous patch to keep the port consistent alongside all other supported platforms.

Approved by:	tcberner (mentor)

net-p2p/transmission-cli: change transmission's data size unit conversion factors from 1000 to 1024, to match FreeBSD's blocksize.

- bump the affected SLAVEPORTS

Submitted by:	soralx@cydem.org (private e-mail)
Approved by:	tcberner (mentor)

net-p2p/tranmission-cli: fix build due to devel/jech-dht update to v0.25.

- bump PORTREVISION of the affected SLAVEPORTS

PR:		234462
Reviewed by:	mat (mentor)
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D18660

Change cmake default behaviour to outsource.

Ports that build out of source now simply can use "USES=cmake"
instead of "USES=cmake:outsource". Ports that fail to build
out of source now need to specify "USES=cmake:insource".

I tried to only set insource where explictely needed.

PR:		232038
Exp-run by:	antoine

Update maintainer eMail address.

Reviewed by:	mat (mentor)
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D17399

net-p2p/transmission* -- update and falvorize

* update to 2.94
* flavorize the Qt frontends
* give maintainership to lebarondemerde@privacychain.ch

PR:		226710
Approved by:	portmgr (mat), crees (previous maintainer)
Differential Revision:	https://reviews.freebsd.org/D14699

- update to miniupnpc 2.1 PR:		228050 Submitted by:	Hung-Yi Chen

- fix python build
- add LICENSE for slave port
- make portlint happier

- bump PORTREVISION on ports using the shared lib

Drop support for expired security/polarssl13

net-p2p/transmission-cli: Fix build with LibreSSL 2.7

- LibreSSL 2.7 adds OpenSSL 1.1 API

PR:		226953
Approved by:	crees (maintainer)

Fix build if libressl is used instead of openssl

Submitted by:	Walter Schwarzenfeld

net-p2p/transmission-cli: Update to 2.93

- Includes DNS rebinding fix
 - Fixes OpenSSL 1.1 compat

Note that the previous version was no longer vulnerable as FreeBSD had
patches, but this reports the correct version to trackers as some were
banned.

PR:		ports/225917
PR:		ports/225915

net-p2p/transmission-daemon: Mitigate DNS rebinding attack

Incorporate upstream pull request 468, proposed by Tavis Ormandy from
Google Project Zero, which mitigates this attack by requiring a host
whitelist for requests that cannot be proven to be secure, but it can
be disabled if a user does not want security.

PR:		225150
Submitted by:	Tavis Ormandy
Approved by:	crees (maintainer)
Obtained from:	https://github.com/transmission/transmission/pull/468#issuecomment-357098126
MFH:		2018Q1
Security:	https://www.vuxml.org/freebsd/3e5b8bd3-0c32-452f-a60e-beab7b762351.html

Remove all _USE=openssl occurrences.

Sponsored by:	Absolight

devel/libevent2: drop historical suffix after r362796

PR:		216777
Approved by:	mm (maintainer)

devel/libevent2: update to 2.1.8 and cleanup

- DEFAULT_VERSIONS += ssl=openssl-devel is now supported
- devel/py-event and devel/p5-Event-Lib are marked BROKEN

Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/whatsnew-2.1.txt
Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/ChangeLog
PR:		216527
Exp-run by:	antoine
Approved by:	mm (maintainer)

Assume "pkg-config zlib" works after 9.x reached EOL

Many ports passed ZLIB_CFLAGS="-I/usr/include" ZLIB_LIBS="-L/usr/lib -lz"
which is unsafe at least with lang/gcc* that override some system headers
and have newer libgcc_s.so that our old version in base may not be
forward-compatible with.

- update miniupnpc to 2.0.20161216 - bump API change

Let USES=localbase add -L${LOCALBASE}/lib to LIBS instead of LDFLAGS. USES=localbase:ldflags can be used to set LDFLAGS.  Normally LDFLAGS appears too early on the command line causing some ports to link with their own libraries in LOCALBASE (if installed) instead of WRKSRC.

Also make use of _USES_POST so -L${LOCALBASE}/lib is added as late as
possible after anything a port Makefile might set.  Use _USES_POST
instead of .include in libedit.mk and libarchive.mk so things like
'USES=libedit localbase:ldflags' work correctly.

Fix some issues with LIBS in some ports.

Switch ports that don't support LIBS to localbase:ldflags.

PR:		212987
Exp-run by:	antoine
Approved by:	portmgr (antoine)

net-p2p/transmission-cli: update mirrors

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

net-p2p/transmission-*: update to 2.92

Changes:	https://trac.transmissionbt.com/wiki/Changes#version-2.92
PR:		207772
Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

net-p2p/transmission-*: update to 2.90

- Add POLARSSL and WOLFSSL support (like ftp/curl)
- Hide LITE (unused) and DOCS (redundant) options from -web slave
- Simplify r398996 and move to CONFIGURE_ENV
- Drop r369657 hacks after upstream integration [1]
- As implied by r378806 transfer maintainership back to crees

Changes:	https://trac.transmissionbt.com/wiki/Changes#version-2.90
PR:		194029 [1]

Clarify LICENSE

net-p2p/transmission-cli: chase r399209

https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

PR:		203768
Reported by:	many
Obtained from:	upstream
MFH:		2015Q4
X-MFH-With:	r399209

Remove iconv(), iconv_open() and iconv_close() symbols from libiconv.

These were FreeBSD specific aliases for libiconv(), libiconv_open() and
libiconv_close() that are now also provided by libc which complicates
writing configure tests that work correctly when both libc iconv and
libiconv are available.

Also, because the libiconv iconv.h header redefines iconv* to libiconv*
correct use of the header implies that the aliases aren't used.

The following ports needed fixes because there was something wrong with
the way they tried to detect or use iconv:

audio/deadbeef: Remove LIBICONV_PLUG from a source file.  It's a
compile-time option and should not be set in source code.
comms/hidapi: Use standard AM_ICONV configure macro to look for iconv.
deskutils/fbreader: Let ports framework deal with LIBICONV_PLUG.
deskutils/ljclive: Override configure test for iconv.
deskutils/owncloudclient: Add USES=iconv and patch test for iconv.
devel/aegis: Bump PORTREVISION because it no longer uses libiconv.
devel/libexplain: Add USES=iconv and override test for iconv.
devel/sdl20: Override configure test for iconv.
emulators/vmw: Replace OSVERSION checks with ICONV_LIB checks and include
<iconv.h> instead of <sys/iconv.h>.
irc/scrollz: Override configure test for iconv.
japanese/chasen-base: Override configure test for iconv and patch
configure so it no longer adds -liconv to linker flags just because it
happens to be installed.
japanses/eb: Patch configure test for iconv.
japanses/eblook: Override configure test for iconv.
java/jikes: Override configure test for iconv.
multimedia/transcode: Bump PORTREVISION because only one plugin links with
libiconv now.
net/c3270: Override configure test for iconv.
net/samba4*: Bump PORTREVISION because it no longer uses libiconv.  The
configure script will always add -liconv to the linker flags when it
happens to be installed which would be wrong but later on binaries are
linked with -Wl,--as-needed and the linker discards -liconv because it
finds iconv*() functions in libc now and no longer in libiconv.
net-mgmt/icinga-*: Remove dependency on iconv.
net-mgmt/netxms: Patch configure so it no longer adds -liconv to linker
flags just because it happens to be installed.
net/asterisk11: Patch configure so it no longer adds -liconv to linker
flags just because it happens to be installed.
net-p2p/transmission-*: Override configure test for iconv.
www/htmlcxx: Override configure test for iconv.
www/httrack: Override configure test for iconv.
www/xapian-omega: Override configure test for iconv.
x11/mrxvt(-devel): Add USES=iconv and override configure test for iconv.
x11/x3270: Override configure test for iconv.
x11-wm/jwm: Override configure test for iconv.

PR:		202838
Exp-run by:	antoine
Approved by:	portmgr (antoine)

Remove trailing whitespace from Makefiles, M-X.

Convert my ports to USES=localbase

net-p2p/transmission-*: minor cleanup

o -cli slave still uses libtransmission under GPLv2
o Chase r313708 in COMMENT for -gtk slave
o Convert LITE to option helpers
o Drop duplicate USES=tar (r362505 vs. r362522)

Don't depend on base OpenSSL when using WITH_OPENSSL_PORT.

PR:		ports/186978
Submitted by:	Bernard Spil

Improve style/consistency among the ports I maintain

- Convert to COPYTREE_SHARE
- Drop unnecessary MKDIR before COPYTREE_SHARE
- Drop bsd.port.options.mk if only DOCS requires it without dependencies
- Use separate backup if several REINPLACE_CMD against the same file
- audio/alsa-utils: convert to LIBS

Differential Revision:	https://reviews.freebsd.org/D1851
Approved by:	bapt (mentor)

- Add CPE information for Transmission ports [1] - Take maintainership [2] as the next update may require partially   reverting r369657 hacks in favor of upstream support - Disable devel/libinotify:   * used only by transmission-daemon's watch-dir   * maybe less stable than readdir() fallback   * disabled by other ports e.g., devel/glib20   * completely different from devel/libnotify [3] - Belated

PR:		197065 [1]
Differential Revision:	https://reviews.freebsd.org/D1806
Suggested by:	crees [2]
Pointy hat:	crees (r287179) [3]
Approved by:	crees (maintainer) [1][2]
Approved by:	bapt (mentor)