net-p2p/transmission-qt

net-p2p/transmission: Update 3.00 -> 4.0.4 & modernize port

This turns previous slave-ports net-p2p/transmission-{cli,daemon,gtk,qt,utils}
and www/transmission-web into flavours of net-p2p/transmission.

What's new in 4.0.4 (vis-a-vis 3.00)
* Resource Efficiency: code profiled and improved
* Code Modernization: standardization on C++ tools
* Support for BitTorrent v2 torrents & hybrid torrents
* New web client
* Lots of bug fixes

Changelog: https://github.com/transmission/transmission/releases/tag/4.0.4

PR:		269504
Reported by:	dutchman01@quicknet.nl
Approved by:	rigoletto, tcberner (maintainer timeout)
Reviewed By:	fcharlier_ploup.net
Differential Revision: https://reviews.freebsd.org/D40910

net-p2p/transmission: Fix build after the libutp changes.

Mk/Uses: always use colon for build/run suffix

Most USES use a colon for build/run(/test) suffixes. Change kde.mk,
qt.mk and pyqt.mk to do the same, and update all ports using that.

Document in CHANGES.

PR:			266034
Exp-run by:		antoine
Approved by:		tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D36349

Fix WWW in parent/child ports

Many of the WWW are overwritten later which means the wrong value
is used. This did not happen before where the children were either
 a) just using the pkg-descr from the parents
 b) or had their own separate pkg-descr with custom WWW

Use WWW?= in parents when the child's WWW is different.

Children that use the same WWW as the parent can just inherit it,
i.e., the child WWW can be removed.

Approved by:	portmgr (implicit)

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

devel/cmake: Update to 3.23.0

Update to 3.23.0.
Fix pkg-plist: using the default share/man location

Release Notes:
  https://cmake.org/cmake/help/v3.23/release/3.23.html

PR:		262886
Exp-run by:	antoine

net-p2p/transmission-*: Fix 'IPv4 DHT announce failed' flooding syslog.

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

net-p2p/transmission-qt: install pixmaps.

- touch net-p2p/transmission-cli

PR:		254372
Submitted by:	Tomasz Kowalczyk <kowalczt.fbsd@gmail.com>

net-p2p/transmission-*: build without debug symbols.

PR:		248326
Submitted by:	ondra@bimovi.cz

net-p2p/transmission-qt: Fix build with NLS=OFF.

net-p2p/transmission: Bring all variants to the latest changes.

- this is supposedly to be the actual 3.00 release

Reported by:	lev

net-p2p/transmission: Fix build.

- upstream modified the v3.00 code without noticing,
  forcing the re-creation of the distinfo file.

- GH_TAGNAME is temporarily set to avoid new surprises.

net-p2p/transmission: Update to 3.00

- net-p2p/transmission-cli
- net-p2p/transmission-daemon
- net-p2p/transmission-gtk
- net-p2p/transmission-qt
- www/transmission-web

Differential Revision:	D18995

Bump PORTREVISION for ports depending on the canonical version of GCC as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3 to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Clean up final leftovers from Qt4.

Submitted by:	rene
Reviewed by:	mat, tcberner
Differential Revision:	https://reviews.freebsd.org/D20725

net-p2p/transmission-qt: remove flavors (Qt4 deprecation)

Approved by:	portmgr (implicit)

net-p2p/transmission-cli: revert the previous patch to keep the port consistent alongside all other supported platforms.

Approved by:	tcberner (mentor)

net-p2p/transmission-cli: change transmission's data size unit conversion factors from 1000 to 1024, to match FreeBSD's blocksize.

- bump the affected SLAVEPORTS

Submitted by:	soralx@cydem.org (private e-mail)
Approved by:	tcberner (mentor)

Fix Qt5 symbol version scripts to put the catch-all clause first.  When a symbol matches multiple clauses the last one takes precedence.  If the catch-all is last it captures everything.  In the case of Qt5 libraries this caused all symbols to have a Qt_5 label while some should have Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)

net-p2p/tranmission-cli: fix build due to devel/jech-dht update to v0.25.

- bump PORTREVISION of the affected SLAVEPORTS

PR:		234462
Reviewed by:	mat (mentor)
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D18660

Use regular DEPRECATED and EXPIRATION_DATE variables in an "if FLAVOR" block instead of flavoring the variables themselves. This caused too much hassle for Tools/scripts/rmport.

Discussed with:	tcberner

Bump PORTREVISION for ports depending on the canonical version of GCC defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Mark QT4 ports/functionality for removal on 2019-03-15

While here, chase some KDE4 ports and functionality, these are scheduled for
removal on 2018-12-31. Change the default option/flavor to QT5 where applicable
or use alternative toolkits like GTK.

Submitted by:	tcberner
Reviewed by:	adridg, jhale, rene, tcberner
Approved by:	portmgr (implicit, flavor hook)
Differential Revision:	https://reviews.freebsd.org/D17741

Fix build with GCC-based architectures.

PR:		231951
Submitted by:	Piotr Kubaj
Approved by:	portmgr (tier-2 blanket)

net-p2p/transmission-qt: Fix plist when NLS is disabled.

Submitted by:	lebarondemerde@privacychain.ch
Approved by:	tcberner (mentor)

net-p2p/transmission* -- update and falvorize

* update to 2.94
* flavorize the Qt frontends
* give maintainership to lebarondemerde@privacychain.ch

PR:		226710
Approved by:	portmgr (mat), crees (previous maintainer)
Differential Revision:	https://reviews.freebsd.org/D14699

Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	→https://reviews.freebsd.org/D15540

net-p2p/transmission-cli: Update to 2.93

- Includes DNS rebinding fix
 - Fixes OpenSSL 1.1 compat

Note that the previous version was no longer vulnerable as FreeBSD had
patches, but this reports the correct version to trackers as some were
banned.

PR:		ports/225917
PR:		ports/225915

Bump PORTREVISION for ports depending on the canonical version of GCC (via Mk/bsd.default-versions.mk and lang/gcc) which has moved from GCC 5.4 to GCC 6.4 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++11-lang,
   c++14-lang, c++0x, c11, or gcc-c++11-lib.

PR:		219275

Add -qt5 port.

While here, correct version of transmission meta-port

PR:		ports/220933
Submitted by:	ldbm@privacychain.ch

Bump PORTREVISIONs for ports depending on the canonical version of GCC and lang/gcc which have moved from GCC 4.9.4 to GCC 5.4 (at least under some circumstances such as versions of FreeBSD or platforms).

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using using Mk/bsd.octave.mk which in turn has USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++14-lang,
   c++11-lang, c++0x, c11, or gcc-c++11-lib.

PR:		216707

devel/libevent2: drop historical suffix after r362796

PR:		216777
Approved by:	mm (maintainer)

devel/libevent2: update to 2.1.8 and cleanup

- DEFAULT_VERSIONS += ssl=openssl-devel is now supported
- devel/py-event and devel/p5-Event-Lib are marked BROKEN

Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/whatsnew-2.1.txt
Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/ChangeLog
PR:		216527
Exp-run by:	antoine
Approved by:	mm (maintainer)

- update miniupnpc to 2.0.20161216 - bump API change

net-p2p/transmission-qt4: unbreak build after r409981

/usr/local/bin/ld: cannot find -lopenssl

Reported by:	pkg-fallout
Pointy hat:	jbeich

net-p2p/transmission-*: update to 2.90

- Add POLARSSL and WOLFSSL support (like ftp/curl)
- Hide LITE (unused) and DOCS (redundant) options from -web slave
- Simplify r398996 and move to CONFIGURE_ENV
- Drop r369657 hacks after upstream integration [1]
- As implied by r378806 transfer maintainership back to crees

Changes:	https://trac.transmissionbt.com/wiki/Changes#version-2.90
PR:		194029 [1]

net-p2p/transmission-cli: chase r399209

https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

PR:		203768
Reported by:	many
Obtained from:	upstream
MFH:		2015Q4
X-MFH-With:	r399209

- Add CPE information for Transmission ports [1] - Take maintainership [2] as the next update may require partially   reverting r369657 hacks in favor of upstream support - Disable devel/libinotify:   * used only by transmission-daemon's watch-dir   * maybe less stable than readdir() fallback   * disabled by other ports e.g., devel/glib20   * completely different from devel/libnotify [3] - Belated

PR:		197065 [1]
Differential Revision:	https://reviews.freebsd.org/D1806
Suggested by:	crees [2]
Pointy hat:	crees (r287179) [3]
Approved by:	crees (maintainer) [1][2]
Approved by:	bapt (mentor)

Cleanup plist

- Add missing -lcrypto (fixup for r364712) - Use MAKE_CMD

transmission-* cleanup

I missed the -linotify LDFLAG on the transmission-gtk port.  It was also
pointed out by the submitter than transmission-qt4 now has a duplicate
-lcrypto LDFLAG so let's remove that.

PR:		192319
Submitted by:	Ivan Klymenko

Convert GMAKE to MAKE_CMD Please note that lots of invocation of MAKE_CMD here are wrong as they do not properly respect MAKE_ENV and friends

With hat:	portmgr

Do not violate stagedir

Reported by:	poudriere
With hat:	portmgr

Fix stage

Stage transmission ports and the rest maintained by me.

Various little obvious fixes, and a new rc script for stunnel-server

- Pass QMAKE_ARGS to qmake

Approved by:	portmgr (blanket approval)

- Remove manual creation and removal of share/applications, as it's now in the mtree (categories starting with [np])

Approved by:	portmgr (bdrewery)