security/putty0.85

security/putty*: Security update 0.84 => 0.85

While here, add USE_XORG+=xrender since pterm seems to be linked to it.

Changelog:	https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html
PR:		297593
Reported by:	mandree (maintainer)
Approved by:	osa, vvd (Mentors, implicit)
MFH:		2026Q3

security/putty: Update to 0.84

Changelog: https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

PR:	295501
Sponsored by:	Netzkommune GmbH

gnome.mk: rename gdkpixbuf2 to gdkpixbuf to prepare for port move

The GTK 1-based gdk-pixbuf has not existed for some time.

No functional or package changes.

security/putty: update to 0.83

Quoting <https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html>,
omitting three Windows items:

These features are new in [PuTTY] 0.83 (released 2025-02-08):

+ Support for ML-KEM, the NIST-standardised post-quantum key exchange
  mechanism. (In addition to NTRU Prime, which has been supported since 0.78.)
+ [...]
+ Bug fix: psftp -b works again.
+ Bug fix: assertion failure if an SSH connection times out at the login
  prompt.
+ Bug fix: crash in Pageant if an SSH connection is abandoned while waiting
  for a deferred decryption passphrase.
+ Bug fix: tight loop if PuTTY tried to send an empty answerback string.
+ Bug fix: accidental truncation of some configuration edit boxes' contents to
  127 characters.
+ [...]
+ Bug fix: restored interoperation with third-party tools that auto-fill login
  prompts by sending ^M for Return.
+ [...]
+ Bug fix: the small keypad keys didn't reliably work in the terminal on Unix.

MFH:		2025Q1

security/putty: update to 20250121's snapshot/Git ec158a2

Bugfix a potential crash, upstream commit message:

    Pageant: call signop_unlink from signop_free.

    A user reported that the following sequence of events leads to Pageant
    crashing:

     - load an encrypted key into Pageant for decryption later
     - attempt to use the key, so that Pageant prompts for the passphrase
     - before entering the passphrase, abort the attempt to use the
       key (e.g. by closing the PuTTY that was trying to use it)
     - now enter the passphrase at the Pageant prompt, once the need for
       it has gone away.

security/putty: bugfix update to 20250117.19798515

This change seems to fix a tight loop that can happen when receiving ^E
in certain configurations.

security/putty: update to 0.83pre 20250114's snapshot

Changelog since 20250105 (the e7ac... patch is also Windows-only):

* e7acb9f6 2025-01-13 | GetDlgItemTextW_alloc: use the right memchr. [Simon Tatham]
* 293be042 2025-01-13 | GTK: cherry-pick font defaults and fallbacks from main. [Simon Tatham]
* f58ddf26 2025-01-07 | Windows: fix leak of a Filename. [Jacob Nevins]
* 457eb612 2025-01-07 | It's a new year. [Jacob Nevins]

security/putty: update to pre-0.83 as of 2025-01-05

changes by Simon Tatham unless otherwise stated, newest first:

* 1e451997 2024-12-26 | Treat SOS and PM terminal escape sequences like APC (HEAD -> pre-0.83, origin/pre-0.83)
* 98200d1b 2024-12-19 | Arm: turn on PSTATE.DIT if available and needed.
* c2077f88 2024-12-19 | Fix compile warnings in tree234 tests.
* 27550b02 2024-12-16 | Windows: inhibit all default application manifests.
* 363debc7 2024-12-15 | lineedit: make both ^M and ^J terminate a line.
* 1fc5f4af 2024-12-15 | wm_size_resize_term: update conf unconditionally.
* 11c7c760 2024-12-15 | Remove bit-rotted RDB_DEBUG_PATCH.
* c91437ba 2024-12-15 | Update cmake_minimum_required to avoid warnings on sid.
* 7802932e 2024-12-15 | Document how to set GIT_SSH_COMMAND to plink -batch.
* 09095a7d 2023-07-15 | Avoid treating non-X GDK display names as X ones [Ben Harris]
* 1ce8ec9c 2024-12-08 | lineedit_send_line: batch up output characters.
* edd5e13f 2024-12-14 | Fix assertion failure on Restart Session.
* f8e1a2b3 2024-12-13 | Windows: rewrite request_file() to support Unicode.
* 22dfc46f 2024-12-13 | Windows: add filename_to_wstr().
* 1ef0fbaa 2024-12-13 | Add helper function dupwcscat().
* 897ecf46 2024-12-11 | SUPDUP: make the TDCRL command clear to end of line.
* 3c6a5139 2024-12-08 | Minimally document ML-KEM key exchange methods. [Jacob Nevins]
* a3f22a2c 2024-12-08 | Use the new 'HYBRID' names for the hybrid KEX packets.
* e98615f0 2024-12-07 | New post-quantum kex: ML-KEM, and three hybrids of it.
* b36d490b 2024-12-07 | Give the kex selection list box a fixed height.
* 16629d3b 2024-12-07 | Add more variants of SHAKE.
* f08da2b6 2024-12-07 | Separate NTRU Prime from the hybridisation layer.
* fcdc804b 2024-12-01 | Move some NTRU helper routines into a header file.
* c2d7ea8e 2024-12-04 | Fix use of aligned_alloc() to be ASan-clean.
* 7da34495 2024-12-07 | Fix error message when KEXINIT negotiation fails.
* 296b6291 2024-12-07 | GTK: fix a crash when clicking Cancel on Change Settings.
* 6a88b294 2024-12-04 | Unix PuTTY/pterm: fix UB with small keypad. [Jacob Nevins]
* b97f20d0 2024-11-30 | release.pl: Adjust pscp/plink transcript updater. [Jacob Nevins]
* 54f6fefe 2024-11-30 | Docs: pscp/plink now need -h/--help to print usage. [Jacob Nevins]
* ebe24534 2024-11-28 | psftp: use cmdline_arg_to_filename for batch files.
* d4e848a9 2024-11-28 | CHECKLST: update for some extra test builds.
* 948a4c8e 2024-11-28 | Fix a compile warning when building with GTK 1.
* 8805cf3d 2024-11-28 | Fix a build failure with NO_GSSAPI defined.
* c72a8627 2024-11-28 | Fix build failures with NO_IPV6 defined.

security/putty: update to 0.82 + cherry-picks

ChangeLog: https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

I have also cherry-picked five patches from the upstream Git repo that
seemed worth having, from https://git.tartarus.org/?p=simon/putty.git

security/putty: SECURITY update to 0.81

This fixes a vulnerability where NIST P521 ecdsa-sha2-nistp521 (only!)
keys can be recovered easily because signature generation in PuTTY used
a biased random number generator.

MFH:		2024Q2
Security:       080936ba-fbb7-11ee-abc8-6960f2492b1d
Security:       CVE-2024-31497

*/*: Bump consumers of x11-toolkits/gtk30

New version of gtk3 in tree

security/putty: security update → 0.80 to fix Terrapin vulnerability

Note this requires the server side to also add the protocol extension.

Security:	91955195-9ebb-11ee-bc14-a703705db3a6
Security:	CVE-2023-48795
Changelog:	https://lists.tartarus.org/pipermail/putty-announce/2023/000037.html
MFH:		2023Q4

security/putty: update → 0.79

ChangeLog: 	https://lists.tartarus.org/pipermail/putty-announce/2023/000036.html
MFH:		2023Q3

accessibility/at-spi2-core: update to 2.46.0

What's new in at-spi2-core 2.46.0:
* Fix GetInterfaces documentation on org.a11y.atspi.Accessible
  interface.

What's new in at-spi2-core 2.45.91:
* Send device event controller events using the same signature as other
  events.
* Document the Accessible, Action, and Cache dbus interfaces.
* Fix license of atspi-gmain.c (#87).

What's new in at-spi2-core 2.45.90:
* xml: Add some documentation.
* xml: Fix event arguments.
* xml: Add some missing DeviceEventController methods.
* Bind the AT-SPI bus to the graphical session.
* Mark bus service as belonging to the session slice.
* Add ATSPI_ROLE_PUSH_BUTTON_MENU.
* Add an "announcement" event/signal to allow objects to send
  notifications (!63).
* Various code clean-ups and test improvements.

What's new in at-spi2-core 2.45.1:
* Atk and at-spi2-atk are now merged into this project.
* Now requires meson 0.56.2 and glib 2.67.4.
* at-spi2-atk: Expose the accessible hierarchy via dbus introspection.
* Properly escape the AT-SPI bus address; fixes warnings about the address
  not containing a colon (!55).
* Add a text value to AtspiValue, so that a value can expose a textual
  description, as in the new Atk value API.
* Add atspi_event_listener_register_with_app, to allow an event listener
  to be registered only for a given application (!52).

- accessibility/atk and accessibility/at-spi2-atk have been merged into
  accessibility/at-spi2-core

- accessibility/at-spi2-core: bump consumers of removed ports atk and at-spi2-atk

PR:		269704
Exp-run by:	antoine
---

security/putty: update to 0.78 release

FreeBSD relevant changes since 20221023 snapshot:

* f9a8213d 2022-10-29 | Docs: add a 'pdf' cmake target. (origin/main, origin/HEAD) [Jacob Nevins]
* 4ff82ab2 2022-10-28 | Update version number for 0.78 release. (tag: 0.78) [Simon Tatham]
* 475c2387 2022-10-28 | Unix: stop accessing ctrl->fileselect for font selectors. [Simon Tatham]
* 329a4cdd 2022-10-24 | authplugin-example.py: Flush stderr. [Jacob Nevins]
* 538c8fd2 2022-10-24 | authplugin-example.py: Mention documentation. [Jacob Nevins]
* a7106d8e 2022-10-23 | Add missing initialisation of term->osc_strlen. [Simon Tatham]
* bdb3ac9f 2022-10-23 | Restrict -pwfile / -pw to apply to server prompts only. [Simon Tatham]
* 2fbb9284 2022-10-23 | Fix outdated comment relating to -pw. [Jacob Nevins]
* f7e86ca2 2022-10-22 | README: remove mention of doc/Makefile. [Jacob Nevins]
* f229aab2 2022-10-23 | Rewrap a paragraph in README. [Jacob Nevins]

MFH:		2022Q4 (after 10 days)

According to Simon, he caught this assertion error in the act,
and 475c2387 should fix
PR:		267253

security/putty: update to snapshot 20221023

FreeBSD-relevant changes since previous snapshot:
* 75ac4443 2022-10-22 | Document subdomain matching of cert expr wildcards. [Jacob Nevins]
* 500568d2 2022-10-22 | Docs: fix trivial typo from 6472f7fc77. [Jacob Nevins]
* 5f3b743e 2022-10-21 | Tweak certified-host-key prompt. [Jacob Nevins]
* bb1ebc9b 2022-10-21 | Docs: tweak certified-host-key warning responses. [Jacob Nevins]
* 5716c638 2022-10-21 | Docs: cross-reference host-key warning sections. [Jacob Nevins]
* 8c534c26 2022-10-21 | Docs: note "wrong host key" warning is stronger. [Jacob Nevins]
* 1d1d81d6 2022-10-21 | Fix regressions in Gtk host key "More info". [Jacob Nevins]
* dc9ab5e0 2022-10-21 | Rename NTRU Prime / Curve25519 kex in UI. [Jacob Nevins]
* 6472f7fc 2022-10-21 | Docs: update Pageant key list description. [Jacob Nevins]
* 5d5a6a8f 2022-10-21 | Docs: MD5 is forced for SSH-1 key fingerprints. [Jacob Nevins]
* d4298308 2022-10-21 | Docs: prime generation defaults are usually fine. [Jacob Nevins]
* 2b5b7b5c 2022-10-21 | Docs: note warning about <2048-bit RSA/DSA keys. [Jacob Nevins]
* 617bf732 2022-10-21 | Docs: PuTTYgen: fix gratuitous exclusion of PSFTP. [Jacob Nevins]
* 11950739 2022-10-21 | Docs: add index alias for "ECDSA". [Jacob Nevins]
* 4af8a585 2022-10-20 | cmdgen: Fix docs and usage messages. [Jacob Nevins]
* 68c97fb2 2022-10-19 | Fix installing man pages from our tarballs. [Jacob Nevins]
* 2222cd10 2022-10-12 | AES-GCM NEON: cope with missing vaddq_p128. [Simon Tatham]

While here, fix PORTVERSION->DISTVERSION to get rid of the tilde
that confuses pkg(8).

And while it may not fix the issue, I still want this commit log
to appear in
PR:		267253

security/putty: fix ARM NEON AES-GCM code

Cherry-pick a test patch from upstream maintainer:

- this uses fallback code for compilers not providing vaddq_p128
  (f.i. clang-10 on FreeBSD 12.3 AMD64/aarch64)
- and uses vaddq_p128 on systems that provide it, for instance,
  FreeBSD 13-STABLE AMD64/aarch64 with clang 14.0.5

Obtained from:	Simon Tatham
MFH:		2022Q4

security/putty: fix aarch64 build on clang 10.

clang 10 (FreeBSD 12.3) does not support vaddq_p128 and similar
ARM NEON intrinsics, but clang 13 (FreeBSD 13.1) does.

Abuse the HAVE_NEON_PMULL cmake test to disable aesgcm-neon.c
unless vaddq_p128() is available.

http://ampere1.nyi.freebsd.org/data/123arm64-quarterly/31229ca1324c/logs/putty-nogtk-0.78~pre20220922.log:
/wrkdirs/usr/ports/security/putty-nogtk/work/putty-0.78~pre20220922.9fcfd67/crypto/aesgcm-neon.c:125:16:
warning: implicit declaration of function 'vaddq_p128' is invalid in C99 [-Wimplicit-function-declaration]
	ctx->acc = vaddq_p128(ctx->acc, load_p128_be(coeff));

security/putty: update to 0.78~pre20220922

This permits a FreeBSD build without patches; the two remaining
items are 1. avoiding the GSSAPI-related call into pkg-config because it
would not cover base-GSSAPI so we force the fallback to krb5-config
(which we control by way of ports/Mk/Uses/gssapi.mk), and
2. making sure PuTTY's build would not ascend directory hierarchy to
pick up our ports tree's Git information. We are only packaging
(pre-)release tarballs where we do not need to run Git.

Thanks to Simon Tatham, upstream maintainer, for issuing the
pre-releases and being very responsive and open to making the
build experience smooth for everyone.

security/putty: add Git patch to fix X11 inclusion

Pull in a fix from upstream's Git to avoid pulling in X11 headers
in no-GTK builds, so we can remove one more local workaround.

security/putty: Update to pre20220919 + 2 Git patches

This allows us to remove all local patch files.

security/putty: permanently remove GSSAPI_DYNAMIC

While it seems a nice idea to load the GSS provider library at run-time,
the existing search code hardwires library versions and only works
with krb5 (MIT Kerberos), and does not attempt to control library paths.

This sort of defeats the purpose, and we do not need a brittle
alternative for a robust GSSAPI_MIT.

So, drop the commented-out GSSAPI_DYNAMIC stuff from the Makefile.

security/putty: Pick right Kerberos version

Make sure that putty only compiles and links against the configured
static GSSAPI version, especially against base even if krb5 or heimdal
are installed.

To that end, hand down the right krb5-config executable,
and punch out pkg-config from the shipped unix.cmake.

security/putty*: clean up options and patches

security/putty: Fix static GSSAPI solutions,

with a patch received from Simon Tatham, and mask GSSAPI_DYNAMIC
for now, because it is not working. Debugging going on, but let's
get GSSAPI working at all for now, and make GSSAPI_BASE the default.

security/putty: upgrade to pre-release 0.78~pre20220916.e1b73f0

ChangeLog: https://lists.tartarus.org/pipermail/putty-announce/2022/000034.html

Please test this thoroughly and if you happen to have a Kerberos-
or GSSAPI-enabled SSH server, please give the maintainer feedback
whether GSSAPI works for you and which GSSAPI library you have
installed.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

cleanup: remove trailing whitepaces

security/putty: update to 0.77

PuTTY 0.77 changed its build system to cmake, and restructured the
source code, thus the patches were regenerated and updated.

As a consequence, GSSAPI_BASE no longer works because cmake wants
pkg-config and hence .pc files.

GSSAPI_HEIMDAL does not compile due to #define (&_foo) xxx.
Both GSSAPI_BASE and GSSAPI_HEIMDAL were disabled. Assistance solicited.

There is a new experimental GSSAPI_DYNAMIC which permits configuring the
GSS provider at run-time, which the package maintainer cannot test
for lack of Kerberized access somewhere. Feedback solicited.

Puttytel was removed upstream, Psusan was added, which is just the inner
SSH protocol layer. See its man page for details.

GTK2 remnants were removed. GTK is currently inseparable from X11,
message was sent to upstream maintainer to see if that is intentional.

Manual pages now install into ${PREFIX}/share/man/man1 (previous
versions of the port installed into ${PREFIX}/man/man1).

Upstream changes: see
https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

No MFH due to intrusive changes and removal of options.

*/*: Remove redundant '-[0-9]*' from CONFLICTS_INSTALL

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

security/putty: Fix CPE information because current one is deprecated

Approved by:    portmgr (blanket)

security/putty: update to 0.76.

FreeBSD relevant changes per
https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

+ New option to abandon an SSH connection if the server allows you to
  authenticate in a trivial manner.
+ Bug fix: user colour-palette reconfiguration via 'Change Settings'
  were delayed-action.
+ Bug fix: server colour-palette reconfigurations were sometimes lost.
+ Bug fix: a tight loop could occur on reading a truncated private key
  file.

security/putty: update to 0.75

https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Deprecate -gtk2 version for Mid-December 2021.

Clean up a bit.

One more small cleanup, forgotten yesterday. Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

security/putty*: take LICENCE file from extracted source,

...rather than copying it into $FILESDIR where it would require
maintenance.

Reported by:	danfe@

security/putty*: rename and update LICENCE from tarball.

security/putty*: rename and update LICENCE from tarball.

security/putty*: upgrade to 0.74 security fix release

Changelog:
https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

among them are these two---and more bugfixes beyond not listed here:

  * Security fix: if an SSH server accepted an offer of a public key
    and then rejected the signature, PuTTY could access freed memory,
    if the key had come from an SSH agent.

  * Security feature: new config option to disable PuTTY's dynamic
    host key preference policy, if you prefer to avoid giving away
    to eavesdroppers which hosts you have stored keys for.

MFH:		2020Q2
Security:       6190c0cd-b945-11ea-9401-2dcf562daa69
Security:       CVE-2020-14002
Security:       FZI-2020-5

WWW/DL link maintenance in pkg-descr and Makefile

...to avoid permanent redirects, or broken sites.

MFH:		2020Q2 (blanket, download/WWW URL chase)

Update to upstream release 0.73 (security fixes)

Relevant changes taken from this...
ChangeLog:	https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

* Security fix: in bracketed paste mode, the terminal escape sequences that
  should delimit the pasted data were appearing together on one side of it,
  making it possible to misidentify pasted data as manual keyboard input.
* Bug fix (possibly security-related): an SSH-1 server sending a disconnection
  message could cause an access to freed memory.
* Bug fix: tweaked terminal handling to prevent lost characters at the ends of
  lines in gcc's coloured error messages.
* Bug fix: removed a bad interaction between the 'clear scrollback' operation
  and mouse selection that could give rise to the dreaded "line==NULL"
  assertion box.

MFH:		2019Q4

Drop the ipv6 virtual category for s* category as it is not relevant anymore

Security update to new upstream release 0.72.

Security fixes found by the EU-funded bug bounty:
- two separate vulnerabilities affecting the obsolete SSH-1 protocol, both available before host key checking
- a vulnerability in all the SSH client tools (PuTTY, Plink, PSFTP and PSCP) if a malicious program can impersonate Pageant

Changelog:	https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Switch off -DSTATIC_GSSAPI build as that produces non-working executables
(assertion failures). Bug has been reported upstream.

MFH:		2019Q3
Security:	5914705c-ab03-11e9-a4f9-080027ac955c

Reinstate GSSAPI_NONE option.

Not bumping PORTREVISION as the default build is unaffected.

Obtained from:	Jacob Nevins, upstream Git commit 7ad08649

Update security/putty to 0.71 security fix release

Unfortunately, this new release breaks GSSAPI_NONE, which is removed
for now. Bug has been reported upstream.

Changelog: https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

MFH:		2019Q1
Security:	46e1ece5-48bd-11e9-9c40-080027ac955c

Reinstate support for GTK2 (rather than GTK3) as an OPTION.

While here, add a putty-gtk2 slave port and update _CONFLICTS.

Since the default package does not change, and pkg would handle conflicts
around attempted installation of the new -gtk2 package, omit the
PORTREVISION bump from Miroslav's original patch.

PR:		227200
Submitted by:	Miroslav Lachman

Retire WITHOUT_DEBUG flag.

The flag has partial support across the tree, and the same effect
can be obtained by using ".undef WITH_DEBUG".

Reviewed by:		mat, rene
Approved by:		portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D12548

Update to 0.70, and make GSSAPI impl. selectable.

PR:		220838
Submitted by:	cy@

security/putty: install icon and .desktop file

PR:		219095
Submitted by:	ehaupt@