x11-toolkits/pangox-compat: fix build with clang 16
Clang 16 has a new error about incompatible function types, which shows
up when building x11-toolkits/pangox-compat:
basic-x.c:687:23: error: incompatible function pointer types assigning to 'void (*)(PangoEngineShape *, PangoFont *, const char *, unsigned int, const PangoAnalysis *, PangoGlyphString *, const char *, unsigned int)' (aka 'void (*)(struct _PangoEngineShape *, struct _PangoFont *, const char *, unsigned int, const struct _PangoAnalysis *, struct _PangoGlyphString *, const char *, unsigned int)') from 'void (PangoEngineShape *, PangoFont *, const char *, gint, const PangoAnalysis *, PangoGlyphString *)' (aka 'void (struct _PangoEngineShape *, struct _PangoFont *, const char *, int, const struct _PangoAnalysis *, struct _PangoGlyphString *)') [-Wincompatible-function-pointer-types]
class->script_shape = basic_engine_shape;
^ ~~~~~~~~~~~~~~~~~~
This is because the 'script_shape' callback function in pango 1.50 has
the 'length' argument as 'unsigned int', and also two additional
parameters 'paragraph_text' and 'paragraph_length'. Even though it looks
like this callback function is never used, correct the arguments to fix
the error.
PR: 271709
Approved by: fluffy (maintainer)
MFH: 2023Q21f905384afPort details
x11-toolkits/pangox-compat0.0.2_4
Deprecated pangoX support
- Maintainer
- gnome@FreeBSD.org
- Packages
- pangox-compat 0.0.2_4
- Upstream
- up to date
- CPE
- none, CVEs only via VuXML
- WWW
- https://www.pango.org/
- Links
- cgit · VuXML
Unaddressed (0) · The CVE record lists this version as affected, no VuXML entry names the CVE
None. There is no CVE without a VuXML entry for this version.
VuXML only (0) · listed, port not fixed yet
None.
pkg audit reports nothing for this version.Fixed (0)
No VuXML entries for this package.
Commits (18)
x11-toolkits/pangox-compat: fix build with clang 15
During an exp-run for llvm 15 (see bug 265425), it turned out that
x11-toolkits/pangox-compat failed to build with clang 15:
pangox.c:983:15: error: incompatible integer to pointer conversion assigning to 'PangoFontMetrics *' (aka 'struct _PangoFontMetrics *') from 'int' [-Wint-conversion]
metrics = pango_font_metrics_new ();
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
pangox-fontmap.c:944:9: error: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion]
char *files_str = pango_config_key_get ("PangoX/AliasFiles");
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because pangox-compat uses two private functions from the main
pango library, which are not declared in the public pango headers.
Fix the errors by adding the two private functions in
pango-impl-utils.h, copying the declarations from pango-font-private.h
and pango-utils-private.h.
PR: 268301
Approved by: fluffy (maintainer)
MFH: 2022Q4c7823054d4Remove WWW entries moved into port Makefiles Commit b7f05445c00f has added WWW entries to port Makefiles based on WWW: lines in pkg-descr files. This commit removes the WWW: lines of moved-over URLs from these pkg-descr files. Approved by: portmgr (tcberner)fb16dfecae
Add WWW entries to port Makefiles It has been common practice to have one or more URLs at the end of the ports' pkg-descr files, one per line and prefixed with "WWW:". These URLs should point at a project website or other relevant resources. Access to these URLs required processing of the pkg-descr files, and they have often become stale over time. If more than one such URL was present in a pkg-descr file, only the first one was tarnsfered into the port INDEX, but for many ports only the last line did contain the port specific URL to further information. There have been several proposals to make a project URL available as a macro in the ports' Makefiles, over time. This commit implements such a proposal and moves one of the WWW: entries of each pkg-descr file into the respective port's Makefile. A heuristic attempts to identify the most relevant URL in case there is more than one WWW: entry in some pkg-descr file. URLs that are not moved into the Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr files in order to preserve them. There are 1256 ports that had no WWW: entries in pkg-descr files. These ports will not be touched in this commit. The portlint port has been adjusted to expect a WWW entry in each port Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as deprecated. Approved by: portmgr (tcberner)b7f05445c0
cleanup: remove '$MCom' tag gnome@ no longer uses Marcusom as their staging ground. Approved by: gnome (nc) Differential Revision: https://reviews.freebsd.org/D3586611049e36cb
x11-toolkits: remove 'Created by' lines A big Thank You to the original contributors of these ports: * 1wardd@airmail.net * Alexander Kabaev <ak03@gte.com> * Alexander Novitsky <alecn2002@yandex.ru> * Alexey Dokuchaev <danfe@FreeBSD.org> * Andreas Kohn <andreas@syndrom23.de> * Andrew Pantyukhin <infofarmer@FreeBSD.org> * Anton Berezin <tobez@FreeBSD.org> * Brian Buchanan <brian@CSUA.Berkeley.EDU> * Cezary Morga <cm@therek.net> * Cheng-Lung Sung <clsung@FreeBSD.org> * Danilo Egea Gondolfo <danilo@FreeBSD.org> * Dima Sivachenko <dima@Chg.RU> * Edwin Groothuis <edwin@mavetju.org> * Eric Anholt <anholt@FreeBSD.org> * Igor Pokrovsky <ip@doom.homeunix.org> * James FitzGibbon <jfitz@FreeBSD.org> * Jean-Sébastien Pédron <dumbbell@FreeBSD.org> * Joe Marcus Clarke <marcus@FreeBSD.org> * Juli Mallett * Kenjiro Cho <kjc@csl.sony.co.jp> * Kimura Fuyuki <fuyuki@hadaly.org> * Koop Mast <kwm@FreeBSD.org> * Lars Koeller <Lars.Koeller@Uni-Bielefeld.de> * Lubomir Marinov <lubomir_m@abv.bg> * Marc Recht <marc@informatik.uni-bremen.de> * Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> * Martin Klaffenboeck <martin.klaffenboeck@gmx.at> * Martin Matuska <mm@FreeBSD.org> * Maxim Sobolev <sobomax@FreeBSD.org> * Michael Grünewald <michipili@gmail.com> * Michael Johnson <ahze@FreeBSD.org> * Mike Krutov <neko@takino.org> * Mike Meyer <mwm@mired.org> * Olivier Duchateau * Paul Schmehl <pauls@utdallas.edu> * Peter Hawkins <thepish@FreeBSD.org> * Piotr Kubaj <pkubaj@anongoth.pl> * Radim Kolar * Rene Ladan <rene@FreeBSD.org> * Robert C. Noland III <rnoland@FreeBSD.org> * Simon Barner <barner@gmx.de> * Stephane Legrand <stephane@FreeBSD.org> * Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> * Thomas Gellekum <tg@FreeBSD.org> * Tom McLaughlin <tmclaugh@sdf.lonestar.org> * Vanilla I. Shu <vanilla@MinJe.com.TW> * Will Andrews <andrews@technologist.com> * Yukihiro Nakai <nakai@FreeBSD.org> * Zane C, Bowers <vvelox@vvelox.net> * asami * chinsan * chuckr * clsung@dragon2.net * dmitry@karasik.eu.org * fjoe@FreeBSD.org * gahr * gena * ijliao * mi * minter@lunenburg.org * nivit@users.sourceforge.net * ports@c0decafe.net * roland.jesse@gmx.net * thierry@pompo.net * vanilla With hat: portmgr71b6a9f9c7
Remove # $FreeBSD$ from Makefiles.305f148f48
x11-toolkits/pangox-compat: prepare for pango >= 1.46.2 PR: 252748 Submitted by: daniel.engberg.lists@pyret.net Obtained from: https://aur.archlinux.org/cgit/aur.git/tree/?h=pangox-compate2fab0a3e2
Add USES=xorg USES=gl, ports categories x Add USES=xorg and USES=gl to ports in categories starting with 'x' While here, try to sprinkle other USES (mostly gnome and sdl) as needed.4c46ca73d8
Remove libintl.so.9 compatibility link that was added in r374303 to prevent massive PORTREVISION bumps. Bump dependent ports that have not been bumped since.f83c7639aa
Remove ${PORTSDIR}/ from dependencies, categories v, w, x, y, and z.
With hat: portmgr
Sponsored by: Absolight72ea7e696b- Drop @dirrm* from and add empty directories to pkg-plists Approved by: portmgr blanket, kwm (for gnome@ ports)fead972aff
Add USES=libtool899267e22c
Remove indefinite articles and trailing periods from COMMENT, plus minor COMMENT typos and surrounding whitespace fixes. A few Makefiles where not included as they contain Latin-1 characters that break the Phabricator workflow. Category X. CR: D511 Approved by: portmgr (bapt)dbc81c7d5b
Convert a bunch of USE_XZ to USES=tar:xz. Approved by: portmgr (not really, but touches unstaged ports)fff296bfe7
Stagify and strip library.ba451907ec
Add NO_STAGE all over the place in preparation for the staging support (cat: x11-toolkits)7e5a7bfffd
The FreeBSD GNOME team presents a Glib and Gtk+ 3 update. This update updates Glib20 to 2.36 and Gtk+ 3.8 * The gio-fam-backend port that used gamin for the GFileMonitor API is gone. It is replaced by a GIO kqueue implementation developed as part of a NetBSD GSoC 2011 project by Dimitry Matveev. * Fix a bug in the glib20 Makefile so it includes -lintl in the glib-2.0 pkgconfig file [1]. This broke static linking and newer binutils. * Add introspection USE_GNOME component which sets GI_SCANNER_DISABLE_CACHE to prevent creation of / root/.cache dir. Defaults to build & run depend, but :build and :run switches available. * New x11-toolkits/pangox-compat port and companion USE_GNOME component for pangox support which was removed from the pango port. Add it to ports still using pangox API. Exp-run by: bapt@ PR: ports/178958 [1] Submitted by: emaste@ [1]a5f590e51d