devel/android-tools 37.0.0

devel/android-tools-adb: glob(3) in FILES doesn't work on FreeBSD 12.0

Convert to UCL & cleanup pkg-message (categories d)

Bump PORTREVISION for ports depending on the canonical version of GCC as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3 to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Add more gettid() aliases to my ports

https://man.openbsd.org/getthrid.2
https://illumos.org/man/3C/thr_self

Switch DragonFly to pthread_getthreadid_np in my ports

https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c0f25c26521a

devel/android-tools-adb: back out r498558 for breaking other BSDs

g++: error: ../libcutils/sockets.o: No such file or directory

devel/android-tools-adb: switch to LIBUSB_CAP_HAS_HOTPLUG whitelist

$ adb connect 1.2.3.4
* daemon not running; starting now at tcp:5037
ADB server didn't ACK
Full server startup log: /tmp/adb.1000.log
Server had pid: 1193
--- adb starting (pid 1193) ---
adb I 12-31 10:41:58  1193     1 main.cpp:56] Android Debug Bridge version 1.0.40
adb I 12-31 10:41:58  1193     1 main.cpp:56] Version 28.0.0-0
adb I 12-31 10:41:58  1193     1 main.cpp:56] Installed as /usr/pkg/bin/adb
adb I 12-31 10:41:58  1193     1 main.cpp:56]
adb F 12-31 10:41:58  1193     1 usb_libusb.cpp:517] failed to register libusb hotplug callback

* failed to start daemon
error: cannot connect to daemon

devel/android-tools-adb: drop FreeBSD < 10.2 support after r430462

devel/android-tools-adb: move SDK_VERSION into vendor Makefile

During major updates SDK version indirectly reflects changed files.

devel/android-tools-adb: drop unused variable after r448522

devel/android-tools-adb: skip manpage on NetBSD as well

make: don't know how to make adb.1. Stop

Bump PORTREVISION for ports depending on the canonical version of GCC defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

devel/android-tools-adb: apply boringssl style fixes

http://github.com/google/boringssl/commit/54091230cda4
http://github.com/google/boringssl/commit/808f8329177f

devel/android-tools-adb: unbreak with OpenSSL 1.1

adb/../libcrypto_utils/android_pubkey.c:84:10: error: incomplete definition of type 'struct rsa_st'
  new_key->n = BN_bin2bn(modulus_buffer, sizeof(modulus_buffer), NULL);
  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:85:15: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->n) {
       ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:90:10: error: incomplete definition of type 'struct rsa_st'
  new_key->e = BN_new();
  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:91:15: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->e || !BN_set_word(new_key->e, key_struct->exponent)) {
       ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:91:42: error: incomplete definition of type 'struct rsa_st'
  if (!new_key->e || !BN_set_word(new_key->e, key_struct->exponent)) {
                                  ~~~~~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:138:18: error: incomplete definition of type 'struct bignum_st'
  BN_ULONG l = in->d[constant_time_select_ulong(
               ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:139:33: error: incomplete definition of type 'struct bignum_st'
      constant_time_le_size_t(in->dmax, i), in->dmax - 1, i)];
                              ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:139:47: error: incomplete definition of type 'struct bignum_st'
      constant_time_le_size_t(in->dmax, i), in->dmax - 1, i)];
                                            ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:142:63: error: incomplete definition of type 'struct bignum_st'
  return constant_time_select_ulong(constant_time_le_size_t(in->top, i), 0, l);
                                                            ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:157:17: error: incomplete definition of type 'struct bignum_st'
  if ((size_t)in->top > (len + (BN_BYTES - 1)) / BN_BYTES) {
              ~~^
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of 'struct bignum_st'
typedef struct bignum_st BIGNUM;
               ^
adb/../libcrypto_utils/android_pubkey.c:210:25: error: incomplete definition of type 'struct rsa_st'
      !BN_mod(n0inv, key->n, r32, ctx) ||
                     ~~~^
/usr/include/openssl/bn.h:247:49: note: expanded from macro 'BN_mod'
 # define BN_mod(rem,m,d,ctx) BN_div(NULL,(rem),(m),(d),(ctx))
                                                 ^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:217:40: error: incomplete definition of type 'struct rsa_st'
  if (!android_pubkey_encode_bignum(key->n, key_struct->modulus)) {
                                    ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:223:30: error: incomplete definition of type 'struct rsa_st'
      !BN_mod_sqr(rr, rr, key->n, ctx) ||
                          ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^
adb/../libcrypto_utils/android_pubkey.c:229:51: error: incomplete definition of type 'struct rsa_st'
  key_struct->exponent = (uint32_t)BN_get_word(key->e);
                                               ~~~^
/usr/include/openssl/ossl_typ.h:110:16: note: forward declaration of 'struct rsa_st'
typedef struct rsa_st RSA;
               ^

Reported by:	pkg-fallout

devel/google{test,mock}: update to 1.8.1

Changes:	https://github.com/google/googletest/compare/9bda90b...release-1.8.1

devel/android-tools-adb: drop unused file after r453204

devel/android-tools-fastboot: drop unused file after r448522

devel/android-tools-adb: adjust for USB dispatch on Windows after r477245

See https://android.googlesource.com/platform/system/core/+/9425996b4521%5E!/

devel/android-tools-adb: unbreak on DragonFly after r477244

adb/client/usb_libusb.cpp: In function 'void libusb::poll_for_devices()':
adb/client/usb_libusb.cpp:493:43: error: unable to find numeric literal operator 'operator""ms'
         if (device_poll_cv.wait_for(lock, 500ms, []() { return terminate_device_poll_thread; })) {
                                           ^~~~~

devel/android-tools-{adb,fastboot}: update to 9.0.0.r3

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.1.0_r2..android-9.0.0_r3/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.1.0_r2..android-9.0.0_r3/fastboot
MFH:		2018Q3 (mostly bug fixes)

Bump PORTREVISION for ports depending on the canonical version of GCC in the ports tree (via Mk/bsd.default-versions.mk and lang/gcc) which has now moved from GCC 6 to GCC 7 by default.

This includes ports
 - featuring USE_GCC=yes or USE_GCC=any,
 - featuring USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and those
 - with USES=compiler specifying one of openmp, nestedfct, c11, c++0x,
   c++11-lib, c++11-lang, c++14-lang, c++17-lang, or gcc-c++11-lib.

PR:		222542

devel/android-tools-fastboot: unbreak fetch

fetch: https://anonscm.debian.org/cgit/android-tools/android-tools.git/plain/debian/fastboot.1?id=706e754: Not Found

Submitted by:	jrm
Differential Revision:	https://reviews.freebsd.org/D15761

devel/android-tools-adb: update SDK version as part of makesum

- Extract platform SDK version out of platform/build repo
- Move version logic out of sub-makefile
- Simplify GH_REVISION

devel/android-tools-{adb,fastboot}: chase SDK version in --version after r456869

Keep in mind, the output is still not identical to upstream.

  $ platform-tools_r26.0.0-linux/adb version
  Android Debug Bridge version 1.0.39
  Revision 3db08f2c6889-android
  Installed as /tmp/platform-tools_r26.0.0-linux/adb

  $ platform-tools_r26.0.0-linux/fastboot --version
  fastboot version 3db08f2c6889-android
  Installed as /tmp/platform-tools_r26.0.0-linux/fastboot

  $ platform-tools_r27.0.0-linux/adb version
  Android Debug Bridge version 1.0.39
  Version 27.0.0-4455170
  Installed as /tmp/platform-tools_r27.0.0-linux/adb

  $ platform-tools_r27.0.0-linux/fastboot --version
  fastboot version 27.0.0-4455170
  Installed as /tmp/platform-tools_r27.0.0-linux/fastboot

  $ adb version
  Android Debug Bridge version 1.0.39
  Version 27.0.0-0 86c2b588a369-android
  Installed as /usr/local/bin/adb

  $ fastboot --version
  fastboot version 27.0.0-0 86c2b588a369-android
  Installed as /usr/local/bin/fastboot

devel/android-tools-{adb,fastboot}: chase HTTP redirect

devel/android-tools-{adb,fastboot}-devel: remove for being older than master port

devel/android-tools-{adb,fastboot}: update to 8.1.0.r2

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r24..android-8.1.0_r2/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r24..android-8.1.0_r2/fastboot

Convert Python ports to FLAVORS.

Ports using USE_PYTHON=distutils are now flavored.  They will
  automatically get flavors (py27, py34, py35, py36) depending on what
  versions they support.

  There is also a USE_PYTHON=flavors for ports that do not use distutils
  but need FLAVORS to be set.  A USE_PYTHON=noflavors can be set if
  using distutils but flavors are not wanted.

  A new USE_PYTHON=optsuffix that will add PYTHON_PKGNAMESUFFIX has been
  added to cope with Python ports that did not have the Python
  PKGNAMEPREFIX but are flavored.

  USES=python now also exports a PY_FLAVOR variable that contains the
  current python flavor.  It can be used in dependency lines when the
  port itself is not python flavored.  For example, deskutils/calibre.

  By default, all the flavors are generated.  To only generate flavors
  for the versions in PYTHON2_DEFAULT and PYTHON3_DEFAULT, define
  BUILD_DEFAULT_PYTHON_FLAVORS in your make.conf.

  In all the ports with Python dependencies, the *_DEPENDS entries MUST
  end with the flavor so that the framework knows which to build/use.
  This is done by appending '@${PY_FLAVOR}' after the origin (or
  @${FLAVOR} if in a Python module with Python flavors, as the content
  will be the same).  For example:

    RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}

PR:		223071
Reviewed by:	portmgr, python
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D12464

devel/android-tools-{adb,fastboot}: update to 8.0.0.r24

Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r4..android-8.0.0_r24/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-8.0.0_r4..android-8.0.0_r24/fastboot

devel/android-tools-adb-devel: update to o.p.4.4534

Changes:	https://android.googlesource.com/platform/system/core/+log/7229576bfed0..612b47630f6f/adb

devel/android-tools-adb-devel: update to o.p.4.4506

Changes:	https://android.googlesource.com/platform/system/core/+log/cfadedb1391f..7229576bfed0/adb

devel/android-tools-adb-devel: unbreak fetch (gzip timestamp changed)

=> Fetched file size mismatch (expected 5257186, actual 5257246)

Reported by:	pkg-fallout

devel/android-tools-{adb,fastboot}-devel: chase platform version output

devel/android-tools-adb-devel: update to o.p.4.4407

Changes:	https://android.googlesource.com/platform/system/core/+log/2066e0585e9d..cfadedb1391f/adb

Bump PORTREVISION for ports depending on the canonical version of GCC (via Mk/bsd.default-versions.mk and lang/gcc) which has moved from GCC 5.4 to GCC 6.4 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++11-lang,
   c++14-lang, c++0x, c11, or gcc-c++11-lib.

PR:		219275

devel/android-tools-adb-devel: unbreak on 10.* after r448542

In file included from adb_auth_host.cpp:33:
adb/../base/include/android-base/file.h:60:63: error: unknown type name 'off64_t'; did you mean 'off_t'?
bool ReadFullyAtOffset(int fd, void* data, size_t byte_count, off64_t offset);
                                                              ^~~~~~~
                                                              off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t         off_t;
                        ^

devel/android-tools-adb-devel: update to o.p.4.185

Changes:	https://android.googlesource.com/platform/system/core/+log/d1e9e7bc06f0..2066e0585e9d/adb

devel/android-tools-adb-devel: switch to master FILESDIR

devel/android-tools-fastboot: sync usb_freebsd.cpp with -devel

devel/android-tools-adb: drop += after r448522

devel/android-tools-fastboot: drop unused file after r448522

devel/android-tools-{adb,fastboot}: update to 8.0.0.r4 (oreo)

Changes:	https://android.googlesource.com/platform/system/core/+log/android-7.1.2_r17..android-8.0.0_r4/adb
Changes:	https://android.googlesource.com/platform/system/core/+log/android-7.1.2_r17..android-8.0.0_r4/fastboot

devel/android-tools-fastboot-devel: drop unused file after r422901

devel/android-tools-adb-devel: oops, don't turn off assert() in logging_test.cpp

devel/android-tools-adb-devel: unbreak TEST=on

[ RUN      ] logging.DCHECK
adb/../base/logging_test.cpp:89: Failure
Death test: {SuppressAbortUI(); if (::android::base::kEnableDChecks) (__builtin_expect( ((false)) != 0, true )) || (false) || ::android::base::LogMessage( "adb/../base/logging_test.cpp", 89, ::android::base::DEFAULT, ::android::base::FATAL, -1).stream() << "Check failed: " "false" << " ";}
    Result: died but not with expected error.
  Expected: DCheck failed: false
Actual msg:
[  DEATH   ] adb_test F 07-02 17:11:02 69537 100707 logging_test.cpp:89] Check failed: false
[  DEATH   ]
[  FAILED  ] logging.DCHECK (1 ms)

[ RUN      ] file.ReadFileToString_WriteStringToFile_symlink
adb/../base/file_test.cpp:55: Failure
      Expected: 62
To be equal to: (* __error())
      Which is: 31
[  FAILED  ] file.ReadFileToString_WriteStringToFile_symlink (0 ms)

[ RUN      ] file.Readlink
adb/../base/file_test.cpp:148: Failure
      Expected: 0
To be equal to: symlink(max.c_str(), max_path.c_str())
      Which is: -1
[  FAILED  ] file.Readlink (0 ms)

devel/android-tools-adb-devel: restore USB transport for < 11.0

https://android.googlesource.com/platform/system/core/+/6da1cd49b5ea%5E%21/

devel/android-tools-{adb,fastboot}-devel: adjust KERN_PROC_PATHNAME after r444135

devel/android-tools-{adb,fastboot}-devel: NetBSD 8 also has KERN_PROC_PATHNAME

https://github.com/NetBSD/src/commit/cbb31237a2ae

devel/android-tools-fastboot-devel: use upstream notation for device paths

$ adb devices -l
List of devices attached
ABCDE1234             device usb:0:2 product:FOO model:BAR device:qux

$ fastboot devices -l
ABCDE1234             fastboot usb:0:2

devel/android-tools-fastboot-devel: oops, fix docs after r444112