net-p2p/transmission 4.1.3

net-p2p/transmission-cli: change transmission's data size unit conversion factors from 1000 to 1024, to match FreeBSD's blocksize.

- bump the affected SLAVEPORTS

Submitted by:	soralx@cydem.org (private e-mail)
Approved by:	tcberner (mentor)

Fix Qt5 symbol version scripts to put the catch-all clause first.  When a symbol matches multiple clauses the last one takes precedence.  If the catch-all is last it captures everything.  In the case of Qt5 libraries this caused all symbols to have a Qt_5 label while some should have Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)

net-p2p/tranmission-cli: fix build due to devel/jech-dht update to v0.25.

- bump PORTREVISION of the affected SLAVEPORTS

PR:		234462
Reviewed by:	mat (mentor)
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D18660

Change cmake default behaviour to outsource.

Ports that build out of source now simply can use "USES=cmake"
instead of "USES=cmake:outsource". Ports that fail to build
out of source now need to specify "USES=cmake:insource".

I tried to only set insource where explictely needed.

PR:		232038
Exp-run by:	antoine

Use regular DEPRECATED and EXPIRATION_DATE variables in an "if FLAVOR" block instead of flavoring the variables themselves. This caused too much hassle for Tools/scripts/rmport.

Discussed with:	tcberner

Bump PORTREVISION for ports depending on the canonical version of GCC defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Mark QT4 ports/functionality for removal on 2019-03-15

While here, chase some KDE4 ports and functionality, these are scheduled for
removal on 2018-12-31. Change the default option/flavor to QT5 where applicable
or use alternative toolkits like GTK.

Submitted by:	tcberner
Reviewed by:	adridg, jhale, rene, tcberner
Approved by:	portmgr (implicit, flavor hook)
Differential Revision:	https://reviews.freebsd.org/D17741

Fix build with GCC-based architectures.

PR:		231951
Submitted by:	Piotr Kubaj
Approved by:	portmgr (tier-2 blanket)

Update maintainer eMail address.

Reviewed by:	mat (mentor)
Approved by:	tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D17399

net-p2p/transmission-qt: Fix plist when NLS is disabled.

Submitted by:	lebarondemerde@privacychain.ch
Approved by:	tcberner (mentor)

net-p2p/transmission-gtk: fix NLS plist

Submitted by:	Alexandre C. Guimarães <lebarondemerde@privacychain.ch> (maintainer)
Reported by:	tijl

net-p2p/transmission -- fix metaport wrt to Qt-flavors, cleanup USE_GNOME

* the metaport was depending on both Qt-flavors
* the gtk slave had redundant dependencies (reported by kwm)

Submitted by:	lebarondemerde@privacychain.ch
Differential Revision:	https://reviews.freebsd.org/D16284

net-p2p/transmission* -- update and falvorize

* update to 2.94
* flavorize the Qt frontends
* give maintainership to lebarondemerde@privacychain.ch

PR:		226710
Approved by:	portmgr (mat), crees (previous maintainer)
Differential Revision:	https://reviews.freebsd.org/D14699

Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	→https://reviews.freebsd.org/D15540

- update to miniupnpc 2.1 PR:		228050 Submitted by:	Hung-Yi Chen

- fix python build
- add LICENSE for slave port
- make portlint happier

- bump PORTREVISION on ports using the shared lib

Drop support for expired security/polarssl13

net-p2p/transmission-cli: Fix build with LibreSSL 2.7

- LibreSSL 2.7 adds OpenSSL 1.1 API

PR:		226953
Approved by:	crees (maintainer)

Fix build if libressl is used instead of openssl

Submitted by:	Walter Schwarzenfeld

net-p2p/transmission-cli: Update to 2.93

- Includes DNS rebinding fix
 - Fixes OpenSSL 1.1 compat

Note that the previous version was no longer vulnerable as FreeBSD had
patches, but this reports the correct version to trackers as some were
banned.

PR:		ports/225917
PR:		ports/225915

net-p2p/transmission-daemon: Improve UPDATING entry and add pkg-message

This will ensure users who do not read UPDATING are still presented with
the message about how to allow clients to connect to the daemon using
DNS when they upgrade the package.

PR:		225150
Reported by:	swills
Security:	https://www.vuxml.org/freebsd/3e5b8bd3-0c32-452f-a60e-beab7b762351.html

net-p2p/transmission-daemon: Mitigate DNS rebinding attack

Incorporate upstream pull request 468, proposed by Tavis Ormandy from
Google Project Zero, which mitigates this attack by requiring a host
whitelist for requests that cannot be proven to be secure, but it can
be disabled if a user does not want security.

PR:		225150
Submitted by:	Tavis Ormandy
Approved by:	crees (maintainer)
Obtained from:	https://github.com/transmission/transmission/pull/468#issuecomment-357098126
MFH:		2018Q1
Security:	https://www.vuxml.org/freebsd/3e5b8bd3-0c32-452f-a60e-beab7b762351.html

Bump PORTREVISION for ports depending on the canonical version of GCC (via Mk/bsd.default-versions.mk and lang/gcc) which has moved from GCC 5.4 to GCC 6.4 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++11-lang,
   c++14-lang, c++0x, c11, or gcc-c++11-lib.

PR:		219275

Add -qt5 port.

While here, correct version of transmission meta-port

PR:		ports/220933
Submitted by:	ldbm@privacychain.ch

Bump PORTREVISIONs for ports depending on the canonical version of GCC and lang/gcc which have moved from GCC 4.9.4 to GCC 5.4 (at least under some circumstances such as versions of FreeBSD or platforms).

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using using Mk/bsd.octave.mk which in turn has USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c++11-lib, c++14-lang,
   c++11-lang, c++0x, c11, or gcc-c++11-lib.

PR:		216707

Remove all _USE=openssl occurrences.

Sponsored by:	Absolight

devel/libevent2: drop historical suffix after r362796

PR:		216777
Approved by:	mm (maintainer)

devel/libevent2: update to 2.1.8 and cleanup

- DEFAULT_VERSIONS += ssl=openssl-devel is now supported
- devel/py-event and devel/p5-Event-Lib are marked BROKEN

Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/whatsnew-2.1.txt
Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/ChangeLog
PR:		216527
Exp-run by:	antoine
Approved by:	mm (maintainer)

Assume "pkg-config zlib" works after 9.x reached EOL

Many ports passed ZLIB_CFLAGS="-I/usr/include" ZLIB_LIBS="-L/usr/lib -lz"
which is unsafe at least with lang/gcc* that override some system headers
and have newer libgcc_s.so that our old version in base may not be
forward-compatible with.

- update miniupnpc to 2.0.20161216 - bump API change

Let USES=localbase add -L${LOCALBASE}/lib to LIBS instead of LDFLAGS. USES=localbase:ldflags can be used to set LDFLAGS.  Normally LDFLAGS appears too early on the command line causing some ports to link with their own libraries in LOCALBASE (if installed) instead of WRKSRC.

Also make use of _USES_POST so -L${LOCALBASE}/lib is added as late as
possible after anything a port Makefile might set.  Use _USES_POST
instead of .include in libedit.mk and libarchive.mk so things like
'USES=libedit localbase:ldflags' work correctly.

Fix some issues with LIBS in some ports.

Switch ports that don't support LIBS to localbase:ldflags.

PR:		212987
Exp-run by:	antoine
Approved by:	portmgr (antoine)

net-p2p/transmission-cli: update mirrors

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

net-p2p/transmission-*: update to 2.92

Changes:	https://trac.transmissionbt.com/wiki/Changes#version-2.92
PR:		207772
Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

net-p2p/transmission-qt4: unbreak build after r409981

/usr/local/bin/ld: cannot find -lopenssl

Reported by:	pkg-fallout
Pointy hat:	jbeich

net-p2p/transmission-*: update to 2.90

- Add POLARSSL and WOLFSSL support (like ftp/curl)
- Hide LITE (unused) and DOCS (redundant) options from -web slave
- Simplify r398996 and move to CONFIGURE_ENV
- Drop r369657 hacks after upstream integration [1]
- As implied by r378806 transfer maintainership back to crees

Changes:	https://trac.transmissionbt.com/wiki/Changes#version-2.90
PR:		194029 [1]

Clarify LICENSE

net-p2p/transmission-cli: chase r399209

https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

PR:		203768
Reported by:	many
Obtained from:	upstream
MFH:		2015Q4
X-MFH-With:	r399209

Remove iconv(), iconv_open() and iconv_close() symbols from libiconv.

These were FreeBSD specific aliases for libiconv(), libiconv_open() and
libiconv_close() that are now also provided by libc which complicates
writing configure tests that work correctly when both libc iconv and
libiconv are available.

Also, because the libiconv iconv.h header redefines iconv* to libiconv*
correct use of the header implies that the aliases aren't used.

The following ports needed fixes because there was something wrong with
the way they tried to detect or use iconv:

audio/deadbeef: Remove LIBICONV_PLUG from a source file.  It's a
compile-time option and should not be set in source code.
comms/hidapi: Use standard AM_ICONV configure macro to look for iconv.
deskutils/fbreader: Let ports framework deal with LIBICONV_PLUG.
deskutils/ljclive: Override configure test for iconv.
deskutils/owncloudclient: Add USES=iconv and patch test for iconv.
devel/aegis: Bump PORTREVISION because it no longer uses libiconv.
devel/libexplain: Add USES=iconv and override test for iconv.
devel/sdl20: Override configure test for iconv.
emulators/vmw: Replace OSVERSION checks with ICONV_LIB checks and include
<iconv.h> instead of <sys/iconv.h>.
irc/scrollz: Override configure test for iconv.
japanese/chasen-base: Override configure test for iconv and patch
configure so it no longer adds -liconv to linker flags just because it
happens to be installed.
japanses/eb: Patch configure test for iconv.
japanses/eblook: Override configure test for iconv.
java/jikes: Override configure test for iconv.
multimedia/transcode: Bump PORTREVISION because only one plugin links with
libiconv now.
net/c3270: Override configure test for iconv.
net/samba4*: Bump PORTREVISION because it no longer uses libiconv.  The
configure script will always add -liconv to the linker flags when it
happens to be installed which would be wrong but later on binaries are
linked with -Wl,--as-needed and the linker discards -liconv because it
finds iconv*() functions in libc now and no longer in libiconv.
net-mgmt/icinga-*: Remove dependency on iconv.
net-mgmt/netxms: Patch configure so it no longer adds -liconv to linker
flags just because it happens to be installed.
net/asterisk11: Patch configure so it no longer adds -liconv to linker
flags just because it happens to be installed.
net-p2p/transmission-*: Override configure test for iconv.
www/htmlcxx: Override configure test for iconv.
www/httrack: Override configure test for iconv.
www/xapian-omega: Override configure test for iconv.
x11/mrxvt(-devel): Add USES=iconv and override configure test for iconv.
x11/x3270: Override configure test for iconv.
x11-wm/jwm: Override configure test for iconv.

PR:		202838
Exp-run by:	antoine
Approved by:	portmgr (antoine)

Remove trailing whitespace from Makefiles, M-X.

Convert my ports to USES=localbase

net-p2p/transmission-*: minor cleanup

o -cli slave still uses libtransmission under GPLv2
o Chase r313708 in COMMENT for -gtk slave
o Convert LITE to option helpers
o Drop duplicate USES=tar (r362505 vs. r362522)

Don't depend on base OpenSSL when using WITH_OPENSSL_PORT.

PR:		ports/186978
Submitted by:	Bernard Spil

- convert to USES=metaport (which removes do_nada in do-install target) - while here replace whitespace with tab for CONFLICT line

Approved by:	portmgr (blanket)

Improve style/consistency among the ports I maintain

- Convert to COPYTREE_SHARE
- Drop unnecessary MKDIR before COPYTREE_SHARE
- Drop bsd.port.options.mk if only DOCS requires it without dependencies
- Use separate backup if several REINPLACE_CMD against the same file
- audio/alsa-utils: convert to LIBS

Differential Revision:	https://reviews.freebsd.org/D1851
Approved by:	bapt (mentor)

- Add CPE information for Transmission ports [1] - Take maintainership [2] as the next update may require partially   reverting r369657 hacks in favor of upstream support - Disable devel/libinotify:   * used only by transmission-daemon's watch-dir   * maybe less stable than readdir() fallback   * disabled by other ports e.g., devel/glib20   * completely different from devel/libnotify [3] - Belated

PR:		197065 [1]
Differential Revision:	https://reviews.freebsd.org/D1806
Suggested by:	crees [2]
Pointy hat:	crees (r287179) [3]
Approved by:	crees (maintainer) [1][2]
Approved by:	bapt (mentor)

Allow use of reload rc command

PR:		ports/195341
Submitted by:	joshruehlig@gmail.com

Cleanup plist

Unbundle libs.

PR:		ports/194029
Submitted by:	Jan Beich

Also, don't extract the third-party directory if we're not using it here.

Submitted by:	mi

- Add missing -lcrypto (fixup for r364712) - Use MAKE_CMD

Fix problems with missing libs when the linker enforces explicit linking (ports that are dependencies of other ports)

net-p2p/transmission-cli: add USES=libtool and remove PTHREAD_LIBS
sysutils/deltup: simplify patch by using MAKE_ARGS
x11-fm/rox-filer: convert to USES=shared-mime-info
x11-wm/emerald: remove PTHREAD_LIBS

PR:		192062